From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E494537B012 for ; Tue, 21 Jul 2026 04:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607865; cv=none; b=nz+t8xp6DOs7Fg9pT8bgt1OEONGZSNk04/ON/D8EFgssjhI+6ylEyXXMs4VwJ6qcrCGagwNAuKvB/KjSjk18nOHK2DXnpsQHxhC4p/wd02uMC4nIPlYxHeXsk1k6FtbVZ+AXKnMzLqV6CLMUmzexR9vahpgd1NPuF3AC8kevsns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607865; c=relaxed/simple; bh=EpyQ6y4Z+XCilzchS+OWjLtr0nkGIpUDEJuyhxPxTFo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IK/aikCwWEXKq4MWoya2EYmPysacqMMf0AdpAIy3/CRJqd9x/zjPAbyoHWt7OstY+CNQbTHqj2IDWEhxruk3PtSppRU2DuC3+ZGtxvPel4vl8IDVa9z0+GqF4ape3tkOyK1JDaVSxGtHZNyJqAIEVCp6ovkzPuhk81nlyzROJhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZSBQ9YDc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=amTCQiwq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZSBQ9YDc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="amTCQiwq" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66L44Cgu534726 for ; Tue, 21 Jul 2026 04:24:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eqqdMOtWVd9xfvkuaRwNW1E678ghvBfZd8MCCpQ39F8=; b=ZSBQ9YDchNLYArbX 3Zc6Wn8yR6NgWc8GKPdJgDcJekFQP1LEl+gcIMBtXFKsG8WQPXNvm83051ZhC2My zAPnFzEuYXWWMxv1MyVs9sSQbrAKtQoUAQJlg1gr+BEsO4XxA/ZjSCc8UHGmaQsW lx002D9CLFqU9S8SH2zbedeVS7xe6E/AwleT+3yJ/5Ie6MtuHLTE4tM7ZU3eIFDC 8QoocP17u79bFuPw1/lqevsJ19DqngnOWZ8UN7fwUS1Tze1KGFCc56kL0M544kC7 ierS2yYwKso6u+K1AgKU7+VM9OP7YoP6eJKy1Y/dAToTcNZxrXM8oJLNQDph9bZJ ruUjnw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1dug27f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 04:24:22 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cc73f47bdcso201049165ad.3 for ; Mon, 20 Jul 2026 21:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784607862; x=1785212662; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=eqqdMOtWVd9xfvkuaRwNW1E678ghvBfZd8MCCpQ39F8=; b=amTCQiwqZQVIg+HPgpM0a/yYPXbwPMMWS7j3ykMTv8uVoI0aQBM7ekRUtG7tK45jCD btAhWNKRQBo5qoXMQt0xBP56j5eLLvgjSkDdurDR1lcI0XhQQoK3NRNtSt6RnVl6u0yu p0TupGlOWXDzShIUQNkPLmyjG0uqZAW/UzzMNV+jBYiEoqJyfCAATd2hCa0TWxUQaBob JpKCXUcMZB3Hjtus+R/YB/Kn2gDEPX9yNLjCbxUaryvw0buJJ/isbuf81DAlS48ncb0D 0zZQrSy1M3A4oiZ4oTewUHiQ4F6WLlStch8I8A7hmtoKPVvAWqmzqsHzN05y0PWWwjRL JcEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784607862; x=1785212662; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eqqdMOtWVd9xfvkuaRwNW1E678ghvBfZd8MCCpQ39F8=; b=Qi/FUDM3G+wGD2D78s7XAbhwUsa54bzyoUbPrJrWDL1d0CFKsyZDleewx3JyVowdOY s1MtubXpqYh+VBJ3lTyi23DVORVdj0ULSD35YeyipMy8xDljWbTQjQSw79Vt6tmWT1Ej aws6qC48UXepRecR2DCT/2lCRhk1IXl8Vtbi2HSS6DmnNDbLIPliRctAeNevVxOgQUbz ULAVunGo8kpkM+bbtX52q9qgtKYnxDDinjv1AeHgk2ACxAht1Vx7uXeSDULFjtE7GzkO FfqY4k2/KBUO9LvhTAvULoAtdYOeRDlrhqZCRieOGigDIsoXgoWdG91Xezk3idhqQ0kH 7RCQ== X-Forwarded-Encrypted: i=1; AHgh+RqJohQ2sccsujIzht9EfNQmkBdVeH4d904QfL5DVxSICzuhVKuHiLIhgqFrxW0PHjE9hfXfI02wZvMAHl8=@vger.kernel.org X-Gm-Message-State: AOJu0YyNZAdzaICUzdJufp9XeilUmoh55XErHHp3HrmOlUfUjxXgytlE d19TQ37IA/gMkpZkhkgHqd68VAeFVUi/NfgEP2ZBgUnR4pMPqHyPlgMqcikbRJaJK4hqp3+fw5N Q2KGGK/HaK/885PblwvvNpE8rvDBtv6tFGxLAHzYSzx75u1aZQZ2iCWWHM9qrwJxOLBM= X-Gm-Gg: AfdE7cneRlQC/CbFakQRMQNduIZTr/ESpBSRyyC00aMH9Bo//zUfalkLjsWJxhxuRua 0SEjYp2+QkHHQGnuBSk5xQEFgLbHlFGLejVImlVm5sKxfKXZ1QY8+H7oxhySHaSFa1GDV0u7UBZ UO7Mr2kXaD/7WnWexocj8lX2RoWNu9V+QsgDjsdATommCZGeRI4qliJd581bnkzZ01xCSkBGVGP /tH+1K72OIsnUAteEnAuLqq8N9axNzzSxzrKImDKqD9Q6c5AW7w8yuA/MdsWyCGw2joX72Hm7BK Sw+B9dAgYUCsWriYaUxZJUMzfcAiVIY9NnjdUnTRqD1qZmGka52cUBCAELvotEtsTPIqJDdSp4i TbrRNKuz9yEvWk06NJR7mTwrpkO7MmGSs X-Received: by 2002:a05:6a21:62c4:b0:3bf:735d:7fb8 with SMTP id adf61e73a8af0-3c3ad640c51mr16441344637.27.1784607861684; Mon, 20 Jul 2026 21:24:21 -0700 (PDT) X-Received: by 2002:a05:6a21:62c4:b0:3bf:735d:7fb8 with SMTP id adf61e73a8af0-3c3ad640c51mr16441324637.27.1784607861223; Mon, 20 Jul 2026 21:24:21 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1bbaf6sm38100411eec.17.2026.07.20.21.24.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 21:24:20 -0700 (PDT) Message-ID: <651ceaac-bdd7-4dbd-ee45-6d4e56f78b39@oss.qualcomm.com> Date: Tue, 21 Jul 2026 09:54:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/2] media: iris: force stage 1 work mode for CBR RC on encoder Content-Language: en-US To: Sachin Kumar Garg , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260717-iris_multi_slice-v2-0-9550b1feb39b@oss.qualcomm.com> <20260717-iris_multi_slice-v2-1-9550b1feb39b@oss.qualcomm.com> From: Vishnu Reddy In-Reply-To: <20260717-iris_multi_slice-v2-1-9550b1feb39b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: mOczush_I62esCuDP4_HOfVzqS2HjiAB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDA0MiBTYWx0ZWRfX0le41IyMz26W naF0fZGMvaPJvieSCGTdlknnkgFreUAxM0mNJc438wLnSGr0Kil3Ler6vYRuPph82rADOxFHfiE 3RYD0mdJyNOlJKVBCZWRu29moCc+R+mJMkZy7iyr3AFx8FJDUK8Flrmj+85HsKj9TE8Cw/PQDIC NqNope17pUn745iBHBy73YSVGb+7pFoNAxlU1iCcZlLW+sxPtQF9HOLlEaxvP/GRnlsNLVwJaLb D4AkK4INwbagTnDXE+Xfsnj6R5VEMQn3v7WnbHwfZbmbCZBtKLdaXP5+Wcw84YrflOBv6zigmG6 jxOeVrtDAl0F78VnsHb/pIerhDRTmb1b+Q6HQZ0vY0r7GnzvP4PpUiftIyecQF07q/dzagu/wJP YFwl7tEgE8LTs1YpWIX9vpQY33NAk7nBupke0vOqX6H3IZ5KqHcGKDcjYoLLNaR9BVyiTTx4QAI T+wXOET8yGNvBGhVyeQ== X-Authority-Analysis: v=2.4 cv=I9JVgtgg c=1 sm=1 tr=0 ts=6a5ef476 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=hhjTFUP8Xi2ExFBNaNkA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: mOczush_I62esCuDP4_HOfVzqS2HjiAB X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDA0MiBTYWx0ZWRfXz4IpPvukcRrj D3Ui7h/qlhSubUhvjB7ONWcxkCEPZ5Q9k9uGU7hvRCVc7cGGKKhck20kMHFR5rMml0JAC8Pjy1q NqI2xC0giTyI2tU8MxoMYbQjJflT/7w= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210042 On 7/17/2026 12:21 PM, Sachin Kumar Garg wrote: > iris_set_stage() currently always picks STAGE_2 for encoder sessions. > CBR rate control requires stage 1 operation, so force STAGE_1 when > BITRATE_MODE is set to CBR. > > The BITRATE_MODE fw_cap value is used instead of inst->hfi_rc_type > since STAGE precedes BITRATE_MODE in enum platform_inst_fw_cap_type, > so iris_set_properties() would still see the previous hfi_rc_type > when iris_set_stage() runs during initial config > > Signed-off-by: Sachin Kumar Garg > --- > drivers/media/platform/qcom/iris/iris_ctrls.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c > index 10e33b8a73f6..6c4eed62d7e3 100644 > --- a/drivers/media/platform/qcom/iris/iris_ctrls.c > +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c > @@ -519,6 +519,9 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id > if (inst->domain == DECODER) { > if (iris_res_is_less_than(width, height, 1280, 720)) > work_mode = STAGE_1; > + } else if (inst->domain == ENCODER) { > + if (inst->fw_caps[BITRATE_MODE].value == V4L2_MPEG_VIDEO_BITRATE_MODE_CBR) > + work_mode = STAGE_1; > } > > return hfi_ops->session_set_property(inst, hfi_id, Reviewed-by: Vishnu Reddy