From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 340BB3B6C07 for ; Tue, 14 Apr 2026 08:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155878; cv=none; b=QbVplJMr7D+x23Iw2i1zIWNjTb4GgHfKN80dg6Asdc3h98VRZkXDKayUvkc/fORihHciVhYsfZ46yPwsnx5bZiksRaT5pzAHPu0rAu/rkHmr4gPhSDbPKap5I4xVkfWotHqomOLbUAXwqwkXk/4MGd8YdjzW1LmJahuNhx/a5jc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155878; c=relaxed/simple; bh=zj1QYxFhf4Oi40i3DmHESB0ZSXDClU16AlMr6gJ+t+I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WLTHHMskMXKmXuukPu39A+609gyy3WsF7uEnByvuaag6htkq20LclrCaEa3vyO5NyiruPNGsHqCJ7jUu3chfv3xRtvrafu5Zz+RPncGxn+jsPuk4VgVujnQRBXCIOBOnnLcBp85TyFvUI+pKuh9LrlFyGiS4e/sa2xRRwXBayrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cwLUaFqW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aPYe8Kxs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cwLUaFqW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aPYe8Kxs" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E6rxWq969085 for ; Tue, 14 Apr 2026 08:37:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d4RCYYRDRdY5PM4k7osDGGtFZVRpfQ8OgMr9WbE+nXQ=; b=cwLUaFqWuKYwLs9S KMThiPB5M95mbO/nrpnHUcvVJPF+SVx4q2HlEa3ougNILvaZlyCIUrYYVVRPkTjR VvyoUd3XhSB5KMI7eavM8Ieb9o4LtPUWyhxEYNmqZPm6WKOlb1bxjzcrYsdo6jT4 /bHbFpcP0YnSPTdUR4wQ8R/EdyXLwYGE/mUVQDcgkEIVZYrgSMyhxgA+gnmnZLoT f7KRm4aiA7gJjHxcNjdw4Ei52wzcIG5M0plrSymsJlWaEc1v7kDJpmE9XKYKXZoU iodt1uLIYjYhdk0aauep+fRv+KqJ1Y2iQVK7dLfcCeueQ8zmyecCLahQUjJzr4LK Zs9C4w== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh86v1sfs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 08:37:55 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b258636d16so52772295ad.2 for ; Tue, 14 Apr 2026 01:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776155874; x=1776760674; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d4RCYYRDRdY5PM4k7osDGGtFZVRpfQ8OgMr9WbE+nXQ=; b=aPYe8KxscGvzb8DPrawNh6MUsbk8GgZEwIlfOMccbkzqc/Zp/CdeGWs8R0izCvB71Q 24mrS4sKdQgXtqiNx6SjypKVgxxetgr4ETQUusIERu9Yo4LKUsVmZkOHK2ENq74YqUh6 mN7YZNJT2bJF0J5VGRSJKfd5XZWi6VOHFieNQw1EeoBKNDNx6zNGk8kQmGBsXe6XpOJ+ Z1KWccAhzJR/AB4vZ2xdTy7C68/vxBDz42agu0MAO3rBg9yGgW90j16Pl7Ihkf3UI6kx Qqz5TLeSzGR0J6mLNVcCMMlpBR+ca/kSirikbShSFPmv6Lg9pvKik9HlK6+CTHfF5F+R ySYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776155874; x=1776760674; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d4RCYYRDRdY5PM4k7osDGGtFZVRpfQ8OgMr9WbE+nXQ=; b=KkNt+5Djwe5BGkB7M6xrJTDbtyvQM6ZW6+t14G1tf1PkovGfzn5bQvvYGzOGamtt3f kxnjJuZLKdq4VsjIbbZJlMgThYYQFqafEQlecjXIv+jtlLcNbyH7uKfqJAMOna7NOMfF 5e8ZdzgBRbPXiv3dWKip9+YRTBHK+9l5UYwv6z0venvV6av/DbuhZ56+9TMNKveQRQUR EnFKYsCcZwspvUqRmEATY6I30SUhOVIsosW5txSdOXDu7JChmqANC8PukbmRqvAlPSPg VqhXd8Q6TxAGn0pGwyzK/kf9/tjoMAFEuZ9eJomsE9r7zQkAn2GFjoAdimChcDnLdt8F UndA== X-Forwarded-Encrypted: i=1; AFNElJ8dK3v9JW2pFpggH1tCS3H9EEYvLVgSju0474xqossR/Y0R+KjQwLKpbv23QMfcUFcWdcDhDkGkRalWQ74=@vger.kernel.org X-Gm-Message-State: AOJu0Yxuec7RYm8yPnl5Kr/3kNyGNzSEglnKnQqt3PATl9VzpuL+5ZDA fzinOvvXisFmlNijgavCUXaWQOmnolccpudSc7JblqIha8dJ+Xp2i3yl/jRrL1zqR04IvNeZNCg fYinQTcuLNv48aoALm/6+s8xH89RDNKaFHxZoeeu3wA9Zi2+cgtASHixLkwMC2KZRUn0= X-Gm-Gg: AeBDieuydIeHqeG7u5DpTx1XqRh3kiLjIndljpK5xPyPC/3S6fLamdrxxzJaviIKGzq fslgbJ6io8VWi9Hn7lolu0/AVsVGMw4jx8Zpg8sizTmYPshBq3jXMtl3+9RzHmStiqdA06mAbq3 G8jL0AuWdpzUiWEQd6OP+1cc+fmiVvoMxxC1u6zKEcQHH2JhUM5NMPzlvdsbZFp/JuUcHi+2em1 7pf+rsjaBg0A9JfJihpomEg0Oa+3j/Al7XmDHV+d6TSXVa3Bx2POVb5wBdL76b8eAcB/aVdHvwB NH79Tv3ltud320FvUp+OsU59at498JvaEvAjJQ4HMrI9PtdCvE+PXa4gfqL38LBldecXNmosl6+ FOcxzHFl5EC3R1ecrkOqiDVtFKDfVDebOdMs7BWspbmokHnfjqg== X-Received: by 2002:a17:903:2f08:b0:2b2:5314:e96a with SMTP id d9443c01a7336-2b2d5a6de57mr179074435ad.34.1776155874023; Tue, 14 Apr 2026 01:37:54 -0700 (PDT) X-Received: by 2002:a17:903:2f08:b0:2b2:5314:e96a with SMTP id d9443c01a7336-2b2d5a6de57mr179074035ad.34.1776155873514; Tue, 14 Apr 2026 01:37:53 -0700 (PDT) Received: from [10.204.79.79] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d4daede9sm181511365ad.14.2026.04.14.01.37.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 01:37:52 -0700 (PDT) Message-ID: <651ec8a6-60e4-4b5a-bdfb-c23c69afb34f@oss.qualcomm.com> Date: Tue, 14 Apr 2026 14:07:47 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/4] misc: fastrpc: Move fdlist to invoke context structure To: Srinivas Kandagatla , linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, andersson@kernel.org, konrad.dybcio@oss.qualcomm.com References: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> <20260402054923.3061925-2-ekansh.gupta@oss.qualcomm.com> <44d79f33-26ea-4a57-b292-74ef474fe0a9@kernel.org> Content-Language: en-US From: Ekansh Gupta In-Reply-To: <44d79f33-26ea-4a57-b292-74ef474fe0a9@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA3OSBTYWx0ZWRfX+/QDGdSNUIjn MaRkRP6tU1vOcKGLeOdiQq0nmvsHQLu4tnvACqQTRAzgn7tIjdOVyQutQ+kf7euGykz0pkqXI31 kWsm6ORru6YjnK0Gb0Xh3SGenxA3ShVhNZR4ShBmLhznWY3AX1UT/PVIjBVsJnVG5BBPrZKWcVR aJdcUSPQavtuo+Zt79NtEGNEYPYZ5BvIk7lIkqIgaEaZsZCHQQTDH2duj1IkwVoxFtjuu2Q20ek /PIrI+Ue4uHg71h5hrgKB5PH3ice+Poue9q4XpcSvmNNN4Aup5hZ7o4ILojpMmfVJwu7zVAhbv2 vFW1E9IkJ5xVdegP+xO+1cFNEDjJ93VJaI9800B4wAGAwC2BJhiDiBX2BTZFTn0g6ltcSxLFweM GWDAA4uzj+lL5+qLa8hqRzX/So3bNTH9JSisRpCKXsrDm7HCiJygKYgNJgrnAnWDFpyCWuUgI8P yO5ouacT3y7Xal6khjQ== X-Proofpoint-ORIG-GUID: ugqsZID2RGhs3C9lAHOACn-yZe_HzG2l X-Authority-Analysis: v=2.4 cv=Iowutr/g c=1 sm=1 tr=0 ts=69ddfce3 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=E3m_rBUOw5yWVkgBiJUA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: ugqsZID2RGhs3C9lAHOACn-yZe_HzG2l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140079 On 13-04-2026 19:38, Srinivas Kandagatla wrote: > > > On 4/2/26 5:49 AM, Ekansh Gupta wrote: >> The fdlist is currently part of the meta buffer which is set during >> fastrpc_get_args(), this fdlist is getting recalculated during >> fastrpc_put_args(). >> >> Move fdlist to the invoke context structure to improve maintainability >> and reduce redundancy. This centralizes its handling and simplifies >> meta buffer preparation and reading logic. >> >> Signed-off-by: Ekansh Gupta >> --- >> drivers/misc/fastrpc.c | 13 ++++--------- >> 1 file changed, 4 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> index 47356a5d5804..11f4ae749e51 100644 >> --- a/drivers/misc/fastrpc.c >> +++ b/drivers/misc/fastrpc.c >> @@ -233,6 +233,7 @@ struct fastrpc_invoke_ctx { >> int pid; >> int client_id; >> u32 sc; >> + u64 *fdlist; >> u32 *crc; >> u64 ctxid; >> u64 msg_sz; >> @@ -1016,6 +1017,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc_invoke_ctx *ctx) >> rpra = ctx->buf->virt; >> list = fastrpc_invoke_buf_start(rpra, ctx->nscalars); >> pages = fastrpc_phy_page_start(list, ctx->nscalars); >> + ctx->fdlist = (u64 *)(pages + ctx->nscalars); >> args = (uintptr_t)ctx->buf->virt + metalen; >> rlen = pkt_size - metalen; >> ctx->rpra = rpra; >> @@ -1118,18 +1120,11 @@ static int fastrpc_put_args(struct fastrpc_invoke_ctx *ctx, >> union fastrpc_remote_arg *rpra = ctx->rpra; >> struct fastrpc_user *fl = ctx->fl; >> struct fastrpc_map *mmap = NULL; >> - struct fastrpc_invoke_buf *list; >> - struct fastrpc_phy_page *pages; >> - u64 *fdlist; >> - int i, inbufs, outbufs, handles; >> + u64 *fdlist = ctx->fdlist; > > fdlist is available after input , output buffers and handles. > > why this is now changed to nscalars? We can replace it as, nscalars = inbufs + outbufs + handles > > --srini >> + int i, inbufs; >> int ret = 0; >> >> inbufs = REMOTE_SCALARS_INBUFS(ctx->sc); >> - outbufs = REMOTE_SCALARS_OUTBUFS(ctx->sc); >> - handles = REMOTE_SCALARS_INHANDLES(ctx->sc) + REMOTE_SCALARS_OUTHANDLES(ctx->sc); >> - list = fastrpc_invoke_buf_start(rpra, ctx->nscalars); >> - pages = fastrpc_phy_page_start(list, ctx->nscalars); >> - fdlist = (uint64_t *)(pages + inbufs + outbufs + handles); >> >> for (i = inbufs; i < ctx->nbufs; ++i) { >> if (!ctx->maps[i]) { >