From: Guenter Roeck <linux@roeck-us.net>
To: Naresh Solanki <naresh.solanki@9elements.com>,
linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] hwmon: (pmbus/core): Implement irq support
Date: Tue, 29 Nov 2022 07:29:11 -0800 [thread overview]
Message-ID: <6522b785-9fcf-93ce-9a0d-6539ca8e18a2@roeck-us.net> (raw)
In-Reply-To: <1b015a86-0d65-8597-0512-b313769e307b@9elements.com>
On 11/29/22 00:16, Naresh Solanki wrote:
> Hi Guenter,
>
> On 29-11-2022 04:39 am, Guenter Roeck wrote:
>> On 11/28/22 09:47, Naresh Solanki wrote:
>>> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>>>
>>> Implement PMBUS irq handler to notify regulator events.
>>>
>>> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>
>> As I am sure I have mentioned before, this needs to primarily handle
>> sysfs notifications to hwmon status attributes and to generate kobject
>> events. Regulator events are secondary / optional.
>
> Based on previous feedback, PMBus interrupt handler is made generic
> Based on the use case I have in my machine, my application need to monitor regulator event as soon as they occur and hence the patch.
>
I understand, but this isn't just about your specific use case. Your use case is
what triggers the change, and ensures that the code change is tested, but the
impact by far reaches beyond your specific use case and needs to address other
(much more common) use cases as well. Interrupt support is needed in the pmbus
code, but it needs to address the common use case first, and that is reporting
the status via sysfs notifications and kobject events.
Thanks,
Guenter
next prev parent reply other threads:[~2022-11-29 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 17:47 [PATCH v2 1/3] hwmon: (pmbus/core): Update regulator flag map Naresh Solanki
2022-11-28 17:47 ` [PATCH v2 2/3] hwmon: (pmbus/core): Add events to " Naresh Solanki
2022-11-28 17:47 ` [PATCH v2 3/3] hwmon: (pmbus/core): Implement irq support Naresh Solanki
2022-11-28 23:09 ` Guenter Roeck
2022-11-29 8:16 ` Naresh Solanki
2022-11-29 15:29 ` Guenter Roeck [this message]
2022-11-30 16:54 ` Naresh Solanki
2022-11-28 22:41 ` [PATCH v2 1/3] hwmon: (pmbus/core): Update regulator flag map Guenter Roeck
2022-11-29 7:55 ` Naresh Solanki
2022-11-29 15:24 ` Guenter Roeck
2022-11-30 16:52 ` Naresh Solanki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6522b785-9fcf-93ce-9a0d-6539ca8e18a2@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®