From: alad@hss.hns.com
To: linux-kernel@vger.kernel.org
Subject: locked page handling
Date: Mon, 31 Dec 2001 15:50:54 +0530 [thread overview]
Message-ID: <65256B33.0039476C.00@sandesh.hss.hns.com> (raw)
In 2.4.16, vmscan.c::shrink_cache(), we have following piece of code -
/*
* The page is locked. IO in progress?
* Move it to the back of the list.
*/
if (unlikely(TryLockPage(page))) {
if (PageLaunder(page) && (gfp_mask & __GFP_FS)) {
page_cache_get(page);
spin_unlock(&pagemap_lru_lock);
wait_on_page(page);
page_cache_release(page);
spin_lock(&pagemap_lru_lock);
}
continue;
}
1) Who is moving the page the back of list ?
2) Is the locked page worth waiting for? I can understand that the page is being
laundered so after wait we may get a clean page but from performance
point of view this is involving unnecessary context switches. Also during
high memory pressure kswapd shall sleep here when it can get more
clean pages on the inactive list ? What are we loosing if we don't wait on
the page and believe that in next pass we shall free this page
-- Amol
next reply other threads:[~2001-12-31 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-31 10:20 alad [this message]
2001-12-31 19:37 ` Andrew Morton
2001-12-31 19:49 ` Andrew Morton
2001-12-31 19:58 ` Daniel Phillips
2001-12-31 20:23 ` Andrew Morton
2002-01-02 4:58 alad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65256B33.0039476C.00@sandesh.hss.hns.com \
--to=alad@hss.hns.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®