From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: "Arnd Bergmann" <arnd@kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Nick Kossifidis" <mickflemm@gmail.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Nathan Chancellor <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>, Aloka Dixit <quic_alokad@quicinc.com>,
Wen Gong <quic_wgong@quicinc.com>,
"Ramya Gnanasekar" <quic_rgnanase@quicinc.com>,
Karthik M <quic_karm@quicinc.com>,
Aditya Kumar Singh <quic_adisi@quicinc.com>,
Muna Sinada <quic_msinada@quicinc.com>,
Johannes Berg <johannes.berg@intel.com>,
<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>
Subject: Re: [PATCH] wireless: ath: remove unused-but-set parameter
Date: Mon, 14 Aug 2023 07:09:00 -0700 [thread overview]
Message-ID: <6529ca77-6ce4-d930-38a4-5ee2f9671bdd@quicinc.com> (raw)
In-Reply-To: <20230814073255.1065242-1-arnd@kernel.org>
On 8/14/2023 12:32 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This has never been used since the driver was merged, but it now causes
> a W=1 warning in recent clang versions
>
> drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
>
> Remove the bit manipulation on the otherwise unused parameter.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I'm wondering if the ath12k change should be separated into its own
patch because 1) it is the most current driver with a dedicated list,
and 2) it actually doesn't generate a warning because changed_flags is
used, just not in a meaningful way. But I'll let Kalle make the call on
that when he returns from holiday.
Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
next prev parent reply other threads:[~2023-08-14 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 7:32 Arnd Bergmann
2023-08-14 14:09 ` Jeff Johnson [this message]
2023-08-14 14:23 ` Toke Høiland-Jørgensen
2023-08-23 14:12 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6529ca77-6ce4-d930-38a4-5ee2f9671bdd@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=jirislaby@kernel.org \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mcgrof@kernel.org \
--cc=mickflemm@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=quic_adisi@quicinc.com \
--cc=quic_alokad@quicinc.com \
--cc=quic_karm@quicinc.com \
--cc=quic_msinada@quicinc.com \
--cc=quic_rgnanase@quicinc.com \
--cc=quic_wgong@quicinc.com \
--cc=toke@toke.dk \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®