From: Dan Williams <dan.j.williams@intel.com>
To: Michal Wilczynski <michal.wilczynski@intel.com>,
<nvdimm@lists.linux.dev>, <linux-acpi@vger.kernel.org>,
<dan.j.williams@intel.com>
Cc: <rafael@kernel.org>, <vishal.l.verma@intel.com>,
<lenb@kernel.org>, <dave.jiang@intel.com>, <ira.weiny@intel.com>,
<linux-kernel@vger.kernel.org>,
Michal Wilczynski <michal.wilczynski@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v3] ACPI: NFIT: Use cleanup.h helpers instead of devm_*()
Date: Tue, 17 Oct 2023 21:28:13 -0700 [thread overview]
Message-ID: <652f5eddba760_5c0d29449@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <20231017082905.1673316-1-michal.wilczynski@intel.com>
Michal Wilczynski wrote:
> The new cleanup.h facilities that arrived in v6.5-rc1 can replace the
> the usage of devm semantics in acpi_nfit_init_interleave_set(). That
> routine appears to only be using devm to avoid goto statements. The
> new __free() annotation at variable declaration time can achieve the same
> effect more efficiently.
>
> There is no end user visible side effects of this patch, I was
> motivated to send this cleanup to practice using the new helpers.
>
> Suggested-by: Dave Jiang <dave.jiang@intel.com>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
> ---
>
> Dan, would you like me to give you credit for the changelog changes
> with Co-developed-by tag ?
Nope, this looks good to me, thanks for fixing it up.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2023-10-18 4:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 8:29 Michal Wilczynski
2023-10-18 4:28 ` Dan Williams [this message]
2023-10-18 10:39 ` Rafael J. Wysocki
2023-12-21 21:25 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652f5eddba760_5c0d29449@dwillia2-mobl3.amr.corp.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=nvdimm@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®