Re: [PATCH] dts: riscv: spacemit: k3: add P1 PMIC regulator tree

[Krzysztof Kozlowski <krzk@kernel.org>]

On 25/03/2026 10:56, Yixun Lan wrote:
> Add the P1 PMIC's regulator topology tree for pico-itx board.
> 
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
> This series try to add a regulator power tree from P1 PMIC,
> the PMIC is controlled via an I2C interface.
> 
> To test this patch, it will need the I2C patch series [1]
> 
> Link: https://lore.kernel.org/all/20260325-02-k3-i2c-v1-0-78f29c83d9ac@kernel.org [1]
> ---
>  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 185 +++++++++++++++++++++++++++
>  arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi |  11 ++
>  2 files changed, 196 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> index b098dbd0e7a1..5b59c569dbde 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> @@ -23,6 +23,191 @@ memory@100000000 {
>  		device_type = "memory";
>  		reg = <0x1 0x00000000 0x4 0x00000000>;
>  	};
> +
> +	reg_dc_in: regulator-dc-in-12v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "dc_in_12v";
> +		regulator-min-microvolt = <12000000>;
> +		regulator-max-microvolt = <12000000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};

This is a pointless supply. It's non-controllable and serves no devices,
so it only bloats the DTB and slows down boot process without any benefits.



> +
> +	reg_aux_vcc3v3: regulator-aux-vcc3v3 {

This is even more pointless because there is no user. Dead code.

> +		compatible = "regulator-fixed";
> +		regulator-name = "AUX_VCC3V3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +		vin-supply = <&reg_dc_in>;
> +	};
> 


Best regards,
Krzysztof