Re: [PATCH 2/2] display: Driver ks0108 and cfag12864b

["Miguel Ojeda" <maxextreme@gmail.com>]

On 9/12/06, Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> arrrrggg....  I'm in the middle of reading every module_init and every
> module_exit func, and this starts getting really annoying....
>

Anyway, thank you for you time reviewing it. :)


>         5. In case of error during initialization, error code SHOULD be
>            propagated as is to upper layers, either via direct
>            assignment/return or via decoding from pointer.
>

What do you mean? I thought returning the error code was enough.


>         6. Error messages SHOULD start with short unique prefix specific to
>            driver. Module name without .o and .ko is fine.

They do 8)

#define PRINTK_PREFIX PRINTK_INFO NAME ": "

printk(PRINTK_PREFIX "Init... ");

Then, if a error appears: printk("ERROR - kmalloc\n");

Final string: "<i>cfag12864b: Init... ERROR - kmalloc"

The only bad point: If some other printk is called from other module
between. Should I change it?


    Miguel Ojeda