From: "Miguel Ojeda" <maxextreme@gmail.com>
To: "Pavel Machek" <pavel@ucw.cz>
Cc: torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk,
greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 Re] drivers: add lcd display support
Date: Wed, 20 Sep 2006 00:08:22 +0200 [thread overview]
Message-ID: <653402b90609191508yff445d4ybf3ee33afb85838d@mail.gmail.com> (raw)
In-Reply-To: <20060919200224.GD7246@elf.ucw.cz>
Ack, thank you for your review!
On 9/19/06, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
> > Please tell me if you agree.
> >
> > Adds LCD Display support.
> > Adds ks0108 LCD controller support.
> > Adds cfag12864b LCD display support.
> >
> > Signed-off-by: Miguel Ojeda Sandonis <maxextreme@gmail.com>
>
>
> > diff -uprN -X linux-2.6.18-rc7/Documentation/dontdiff linux-2.6.18-rc7-vanilla/drivers/lcddisplay/cfag12864b.c linux-2.6.18-rc7/drivers/lcddisplay/cfag12864b.c
> > --- linux-2.6.18-rc7-vanilla/drivers/lcddisplay/cfag12864b.c 1970-01-01 01:00:00.000000000 +0100
> > +++ linux-2.6.18-rc7/drivers/lcddisplay/cfag12864b.c 2006-09-13 05:03:29.000000000 +0200
> > @@ -0,0 +1,558 @@
> > +/*
> > + * Filename: cfag12864b.c
> > + * Version: 0.1.0
> > + * Description: cfag12864b LCD Display Driver
> > + * License: GPL
>
> v2 or v2 and later?
>
> > +static const unsigned int cfag12864b_firstminor = 0;
>
> No need to initialize to zero.
>
> > +static const unsigned int cfag12864b_ndevices = 1;
> > +static const char * cfag12864b_name = NAME;
> ~- kill this space.
>
> > +#define bit(n) ((unsigned char)(1<<(n)))
> > +#define nobit(n) ((unsigned char)(~bit(n)))
>
> Uh? We have generic functions for this.
>
> > +static unsigned char cfag12864b_state = 0;
>
> No zeros.
>
> > +static void cfag12864b_e(unsigned char state)
> > +{
> > + if(state)
> ~ missing space.
>
> > + cfag12864b_state |= bit(0);
> > + else
> > + cfag12864b_state &= nobit(0);
> > + cfag12864b_set();
>
> This repeats few times, perhaps you could create helper for that?
> > +static void cfag12864b_secondcontroller(unsigned char state)
> > +{
> > + if(state)
> > + cfag12864b_cs2(0);
> > + else
> > + cfag12864b_cs2(1);
> > +}
>
> Is this needed?
>
> > + /*if(address != tmpaddress) {
> > + address = tmpaddress;
> > + cfag12864b_address(address);
> > + cfag12864b_nop();
> > + }*/
> > +
> > + /*if(tmpcontroller == 0) {
> > + if(address != tmpaddress) {
> > + address = tmpaddress;
> > + cfag12864b_address(address);
> > + }
> > + }
> > + else {
> > + cfag12864b_address(tmpaddress);
> > + cfag12864b_nop();
> > + }*/
>
> Remove unused code, do not comment it out.
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
prev parent reply other threads:[~2006-09-19 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 1:05 Miguel Ojeda Sandonis
2006-09-19 20:02 ` Pavel Machek
2006-09-19 22:08 ` Miguel Ojeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653402b90609191508yff445d4ybf3ee33afb85838d@mail.gmail.com \
--to=maxextreme@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome