From: "Miguel Ojeda" <maxextreme@gmail.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18 real-V5] drivers: add lcd display support
Date: Wed, 27 Sep 2006 20:58:24 +0000 [thread overview]
Message-ID: <653402b90609271358m58950e96k99b2314f9732b5ef@mail.gmail.com> (raw)
In-Reply-To: <20060926120821.e11f3254.akpm@osdl.org>
On 9/26/06, Andrew Morton <akpm@osdl.org> wrote:
> It's also probably-incorrect on big-endian CPUs.
> Perhaps you should not
> use bitops at all for this driver, use open-coded |
> and &/~ instead?
Uhm, someone told me that they shouldn't be used because the kernel
has generic functions for that.
I researched the kernel sources, and looking at bitops.h I found
setbit(), so I tried to use it in the driver, althought I prefer
standard |= and &=.
Are there more generic bitops kernel functions I may didn't find and I
should use in the future?
Anyway, it's just a question: I will turn back the driver to use |=
and &=, they look better to me too.
next prev parent reply other threads:[~2006-09-27 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 20:03 Miguel Ojeda Sandonis
2006-09-26 19:08 ` Andrew Morton
2006-09-27 20:58 ` Miguel Ojeda [this message]
2006-09-27 22:42 ` Andrew Morton
2006-09-28 19:20 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653402b90609271358m58950e96k99b2314f9732b5ef@mail.gmail.com \
--to=maxextreme@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®