From: "Miguel Ojeda" <maxextreme@gmail.com>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab.c: whitespace cleanup
Date: Mon, 6 Nov 2006 16:27:46 +0000 [thread overview]
Message-ID: <653402b90611060827t7eaff5acl1a5cbc36c772ba29@mail.gmail.com> (raw)
In-Reply-To: <84144f020611060818t5890143cn32865750073e602c@mail.gmail.com>
On 11/6/06, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> On 11/6/06, Miguel Ojeda Sandonis <maxextreme@gmail.com> wrote:
> > whitespace cleanup for mm/slab.c
>
> [snip]
>
> > - addr = (unsigned long *)&((char *)addr)[obj_offset(cachep)];
> > + addr = (unsigned long *)((char *)addr + obj_offset(cachep));
>
> Call me old-fashioned, but this doesn't count as whitespace cleanup.
> Anyway, why do you want to do this? The coding style changes seem too
> minor to be worth it...
>
> Pekka
>
Isn't "p+i" more correct / easy to understand than "&p[i]"?
next prev parent reply other threads:[~2006-11-06 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 16:47 Miguel Ojeda Sandonis
2006-11-06 16:18 ` Pekka Enberg
2006-11-06 16:27 ` Miguel Ojeda [this message]
2006-11-06 16:47 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653402b90611060827t7eaff5acl1a5cbc36c772ba29@mail.gmail.com \
--to=maxextreme@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®