From: Miaohe Lin <linmiaohe@huawei.com>
To: Yuanhe Shu <xiangzao@linux.alibaba.com>
Cc: "Huang, Ying" <ying.huang@linux.alibaba.com>,
Kaitao Cheng <kaitao.cheng@linux.dev>,
"Garg, Shivank" <shivankg@amd.com>, <vbabka@kernel.org>,
<ljs@kernel.org>, <liam@infradead.org>, <rppt@kernel.org>,
<surenb@google.com>, <mhocko@suse.com>, <nao.horiguchi@gmail.com>,
<ziy@nvidia.com>, <wangkefeng.wang@huawei.com>,
<tujinjiang@huawei.com>, <mgorman@techsingularity.net>,
<chengkaitao@kylinos.cn>, <muchun.song@linux.dev>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<akpm@linux-foundation.org>, <david@kernel.org>
Subject: Re: [PATCH v3] mm/highmem: refuse to copy hwpoisoned folios in the !copy_mc fallbacks
Date: Thu, 19 Nov 2026 17:23:41 +0800 [thread overview]
Message-ID: <6536c6f9-4cab-9f64-53fc-897f3bd9c9a8@huawei.com> (raw)
In-Reply-To: <20261110112641.1196786-1-xiangzao@linux.alibaba.com>
On 2026/11/10 19:26, Yuanhe Shu wrote:
> The !copy_mc fallbacks of copy_mc_user_highpage() and
> copy_mc_highpage() return 0 after a plain copy. With PG_hwpoison
> set while the data stays readable, there is no fault to recover
> from: the copy completes, the destination folio carries no poison
> marker, and the poison is consumed silently.
>
> Check the source page with is_page_hwpoison() in both fallbacks,
> before the copy, and return PAGE_SIZE, the not-copied-bytes
> convention of the real copy_mc paths, so the callers take their
> existing error paths. On archs with copy_mc this code does not
> compile.
>
> Measured on arm64, where the fallback code compiles: a
> kernel-space microbenchmark measures 90.00 ns per copy before the
> patch and 90.71 ns after, 0.8% of the copy itself.
>
> Suggested-by: "Huang, Ying" <ying.huang@linux.alibaba.com>
> Suggested-by: Kaitao Cheng <kaitao.cheng@linux.dev>
> Assisted-by: LLM
> Signed-off-by: Yuanhe Shu <xiangzao@linux.alibaba.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks.
.
prev parent reply other threads:[~2026-11-19 9:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:26 Yuanhe Shu
2026-11-11 1:54 ` Huang, Ying
2026-11-11 9:36 ` David Hildenbrand (Arm)
2026-11-11 10:14 ` Kefeng Wang
2026-11-11 11:10 ` Weilin Tong
2026-11-11 18:19 ` Catalin Marinas
2026-11-17 21:42 ` David Hildenbrand (Arm)
2026-11-18 14:56 ` David Hildenbrand
2026-11-19 9:23 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6536c6f9-4cab-9f64-53fc-897f3bd9c9a8@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=chengkaitao@kylinos.cn \
--cc=david@kernel.org \
--cc=kaitao.cheng@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=rppt@kernel.org \
--cc=shivankg@amd.com \
--cc=surenb@google.com \
--cc=tujinjiang@huawei.com \
--cc=vbabka@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=xiangzao@linux.alibaba.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®