From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
moderated for non-subscribers <alsa-devel@alsa-project.org>
Cc: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: sound/soc/sof/: fix kconfig dependency warning
Date: Mon, 6 May 2019 14:43:08 -0500 [thread overview]
Message-ID: <653fcfc0-8285-acbb-8eac-39d0e6f8176e@linux.intel.com> (raw)
In-Reply-To: <418abbd5-f01c-19ef-c9f2-7de5662f10a2@infradead.org>
On 5/6/19 2:01 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig warning for unmet dependency for IOSF_MBI when
> PCI is not set/enabled. Fixes this warning:
>
> WARNING: unmet direct dependencies detected for IOSF_MBI
> Depends on [n]: PCI [=n]
> Selected by [y]:
> - SND_SOC_SOF_ACPI [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_SOF_TOPLEVEL [=y] && (ACPI [=y] || COMPILE_TEST [=n]) && X86 [=y]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: alsa-devel@alsa-project.org
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
I completely forgot to mirror the change in sound/soc/intel/Kconfig for
IOSF support (ASoC: Intel: atom: Make PCI dependency explicit) for the
same issue that ACPI no longer depends on PCI, thanks Randy for spotting
this.
> ---
> sound/soc/sof/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20190506.orig/sound/soc/sof/Kconfig
> +++ linux-next-20190506/sound/soc/sof/Kconfig
> @@ -28,7 +28,7 @@ config SND_SOC_SOF_ACPI
> select SND_SOC_ACPI if ACPI
> select SND_SOC_SOF_OPTIONS
> select SND_SOC_SOF_INTEL_ACPI if SND_SOC_SOF_INTEL_TOPLEVEL
> - select IOSF_MBI if X86
> + select IOSF_MBI if X86 && PCI
> help
> This adds support for ACPI enumeration. This option is required
> to enable Intel Haswell/Broadwell/Baytrail/Cherrytrail devices
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
next prev parent reply other threads:[~2019-05-06 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 19:01 Randy Dunlap
2019-05-06 19:43 ` Pierre-Louis Bossart [this message]
2019-05-07 2:28 ` Applied "ASoC: sound/soc/sof/: fix kconfig dependency warning" to the asoc tree Mark Brown
2019-05-07 2:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653fcfc0-8285-acbb-8eac-39d0e6f8176e@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome