From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8FC62BEC3F for ; Tue, 9 Jun 2026 11:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781002853; cv=none; b=GzxWOTOYXquB4j500LsaobbAVKLRcdmyBeF4uo/Y0QlcalwLQ7YfreEI9Ac8z7qxJZ0U0t43dpkBYLomeGnusyPVFWaBhq/ZX0vdtns4hZEy5u3VCn88kBx1LEWl738PsFQyHTlxiVqfAOs649HfQzzQQhmj6vXRkpSD+cD1gCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781002853; c=relaxed/simple; bh=y1rowJMxQaGWb4JIfksAagTPim0cmlPxRHjXj8mdpeI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=isZlHM2L6v7MEqMrfHaUNfC9AQojUC+xfkfYylSpU4UB1dJ5k5zCslHx/65QI3WKn6qRWHkfm85lf1LBumdabdYSnxKRSgQPKIg99ohuidway9WjGrMeE05t71tKV/FN1+EYYKJFK85LVwDRR9w0U3AtZBG61TUcZqiFzvZ0B/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ROLS+Rf0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f5QB/QFx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ROLS+Rf0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f5QB/QFx" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6599wnB22311308 for ; Tue, 9 Jun 2026 11:00:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QGn80Czw+Q8aNgWthHK97QTsMBMg/HtanGxumcKLgUM=; b=ROLS+Rf0RgXL7Gvn tkk8FHreJAvZqLmANpC9Cqsjv4rLZno2Hp4Xb+0FGvV6Gf7TUuZHcgyeDfXhFBDY b/KAn2USklQFfwhU+8eCn56An2IqQeaIbyy79jTXUdHJxBgvl5tOQ4JE8R7hgqkL n4WwzQxKGvVtN4/1z29X3Qi0LXzCSuhGyYYj6kIK7VhWmFKA4kW7XGUFxUENsYf6 kk1DDCD8ROHxI4hckxJoymPl9retNx7KIYSFioTf31F7EZDqBNyZlo7dRK9clnLo C2j5Bb0Yml+Ib6QrndeDwj7rXGu0WmMQ8iAkPLR+ki9ntHijhP5KE7Ze7zVK/BXK VI4p9Q== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epg3v0brf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 11:00:50 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2bf30576aa3so38209335ad.3 for ; Tue, 09 Jun 2026 04:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781002850; x=1781607650; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QGn80Czw+Q8aNgWthHK97QTsMBMg/HtanGxumcKLgUM=; b=f5QB/QFxIQx0IiVUsOvov5ycl3PdEI6XmoKFMF3wutpG6VH7GF0mXDwfFbn/fjB9T4 swUajfs/J0L+Hrg/owAPKRBY5XYY9EMrOEV/vH/LeV6zKVWZ/QQlQ/mOnCDjTGOwv1Nb 8mvCgPkE8sZhM5heR3A4sQ0wRm24gAsvCcK1m38R0RPqxO5DxD9iaTZiZJ5+VY7n182i xZCrh0WSIQDZn3lYQpdkjo+uSUKHsTR0Qh1U80FgJ94agoKVhfGNdT/R0XjxwCiWqKUG s31jadSYucAQSubxrf6GM2MumQHGeYingeklhaKWZdIcvcMN6KKdm0FBovmddDX2Ip+Y 4i1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781002850; x=1781607650; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QGn80Czw+Q8aNgWthHK97QTsMBMg/HtanGxumcKLgUM=; b=BVX2oCx+KtGE8gGnnUcqJ1U9IAva71WRJqYU370NuZBx/vCGIIGXg7wk2R3ZTv+Ob7 mz2k+unSEQ6JoVspjJMNUCeA7a8j2zQtXKjJnMSho/UFi0ghOxVUIADGQ3GJ2ms5y/mt giMVC3nirJNMs/PGQ+PlV1diVHijMyHRjHuU6RoP64ml+IvTfwlVjjpRZGH+bvqKiXFI dowpgrkaNXtO+OVykKSQUzrA8YYBDCVvjWJTJpQvjE3PM+dZ9vwOMXhnpV8dn+4856r5 uQ4pP43RMyPFpqTZToJkc3STR581E7tzURtr5YppqSpikyU3WziMI4UnXEkYfHjQ/P2k spLA== X-Forwarded-Encrypted: i=1; AFNElJ+FIXth61FX+PeUFMaqD6O7sABT8iRSYVBZFoTa2tXLgd2rrqjfDeJDYDXeAdfYtoiQWzGUl57hBTn3t2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyI+xmv+OeW/+zr2O1Mv7nvG0M6c9bX+1FKFSaPG7u8l0yD8fzS 1FI7tvt+uFNNqlUeteK3zs+se6uBTwDjTz2CRXaeBscDh7JzcGU8kjSJdUpvq8fd8Nt7ja7QfDJ qNeAy8KlckAZTKFtSNbjQFTuDevBemLPvKhpLkc4sjbvQ3CAXu7Nii6ATbrmr83vcV4kjJZHzVZ w= X-Gm-Gg: Acq92OHJMmquxBufXfP5M6H4P3u8k/Y9JYBeBr+u8x6Lhcn3/0bDRC64sTH2r/LgzfI Dwlp9QiXx49DKfL66nu5k23e5Dg735JiKRLWkXd9gRlKbhZNyP67Fcfv1cDxznaa0/1bz3m4DlQ LvEk9di1lCl2JG74O3MSmFim8Aq4pXKFOc9e1vR6dyEfwxodWkwtqqUGt3bge8ozjTckrWCa4c0 VrPY0m5slexJ8QdwWGQLwcvCjx3JTcew343TGHgn8NKxJTL1bJafEjqk8D3jFD/Ejve1E7S+eqb xcRowZWiLWidZoymhIMvCK2dXCDdK7QM/iWKfH8Snv6UPFGCTuQXDhGQozbndnaT16RrO9ZO5Bv 4geUMLbUwTou19Jf04bPedz0arp9l1BO+H0Ixqp+a1gfsCHW9IVVRY1enb0AqBnqsh0enhh0t X-Received: by 2002:a17:902:f541:b0:2b7:975c:dacc with SMTP id d9443c01a7336-2c2a1bb43e7mr30141285ad.1.1781002849607; Tue, 09 Jun 2026 04:00:49 -0700 (PDT) X-Received: by 2002:a17:902:f541:b0:2b7:975c:dacc with SMTP id d9443c01a7336-2c2a1bb43e7mr30140895ad.1.1781002849195; Tue, 09 Jun 2026 04:00:49 -0700 (PDT) Received: from [10.152.199.23] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f875casm211576805ad.22.2026.06.09.04.00.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 04:00:48 -0700 (PDT) Message-ID: <6545e04a-eded-42a2-b773-92d9e9ed2226@oss.qualcomm.com> Date: Tue, 9 Jun 2026 16:30:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath11k: fix refcount leak in ath11k_ahb_fw_resources_init() To: Wentao Liang , jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260609092528.220547-1-vulab@iscas.ac.cn> From: Rameshkumar Sundaram Content-Language: en-US In-Reply-To: <20260609092528.220547-1-vulab@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=St6gLvO0 c=1 sm=1 tr=0 ts=6a27f262 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=q36DTRNDronnURX6cDEA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: sBSnEQlso8DbUG7W8LGeTHZbqq_L1U0U X-Proofpoint-GUID: sBSnEQlso8DbUG7W8LGeTHZbqq_L1U0U X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDEwMyBTYWx0ZWRfX3SvzxcAdbuhh KaYgEzJO7EsgUOIGdXOqJY3S0BiNbdhpQ8i8IGU6/SPzZ7F0VhwddInTqQ4MBq8fwZbASUvj0fk 5x9wgkLn7NGZsA9fObsrlqzNTfxTvnLTp6F1O+gzEakcZpNNEehwvnzYJ7ffUGW0N4zeIkt+dC9 EtRZ0Fmbam16cyiokfqB8HfUiiCOQ6w2EZvmNt1SoVqKCDOLBe8XKS/YpeXktprrIHNPxqol+eu W8CZBQsNmyxKYcVWDmvN98bnu62wZJl5ZB5AqoM4Hl9ijdeKeAisIR0md3Tai1FCFojic2oGSoh +sLIztOih/nPzCmYimfDKLh0ZKgmuMQCHuqaF8tIC3RA/vssyvndF8KRsMlmMTMIbxwCAGRXD6b v8pY2qHEQ/c4R6hFkinPz6eDDg/WMAQtsBEEg/eahuSpem5XCWaoTuSCB06WjKLrKqrcybCIJO5 ZMrLZRt1ddLBDcmWhLA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090103 On 6/9/2026 2:55 PM, Wentao Liang wrote: > of_get_child_by_name() returns a node pointer with refcount > incremented, but the error path when ath11k_ahb_setup_msa_resources() > fails does not release it. Add the missing of_node_put() to avoid > leaking the reference. > > Cc: stable@vger.kernel.org > Fixes: 095cb947490c ("wifi: ath11k: allow missing memory-regions") > Signed-off-by: Wentao Liang Reviewed-by: Rameshkumar Sundaram