From: Stefan Agner <stefan@agner.ch>
To: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: shawn.guo@freescale.com, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support
Date: Fri, 19 Sep 2014 18:03:42 +0200 [thread overview]
Message-ID: <6548345144e6eb9f252bfa35e9783079@agner.ch> (raw)
In-Reply-To: <bae435d33cac93fd5f0c763fbe7bb302b52a6f0f.1411130205.git.bhuvanchandra.dv@toradex.com>
Am 2014-09-19 15:38, schrieb Bhuvanchandra DV:
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++
> arch/arm/boot/dts/vf610-colibri.dtsi | 6 ++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> index 00f63d9..711cf82 100644
> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> @@ -19,6 +19,12 @@
> };
> };
>
> +&bl {
> + brightness-levels = <0 4 8 16 32 64 128 255>;
> + default-brightness-level = <6>;
> + status = "okay";
> +};
> +
> &esdhc1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_esdhc1>;
> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi
> b/arch/arm/boot/dts/vf610-colibri.dtsi
> index 560cd69..20b1c15 100644
> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
> @@ -13,6 +13,12 @@
> model = "Toradex Colibri VF61 COM";
> compatible = "toradex,vf610-colibri_vf61", "fsl,vf610";
>
> + bl: backlight {
> + compitable = "pwm-backlight";
> + pwms = <&pwm0 0 5000000 0>;
> + status = "disabled";
> + };
> +
Typo, "compitable" is not a valid property...
When this is fixed,
Acked-By: Stefan Agner <stefan@agner.ch>
> clocks {
> enet_ext {
> compatible = "fixed-clock";
next prev parent reply other threads:[~2014-09-19 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:38 [PATCH v2 0/2] Add PWM and backlight support for Colibri VF61 modules Bhuvanchandra DV
2014-09-19 13:38 ` [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support Bhuvanchandra DV
2014-09-19 16:00 ` Stefan Agner
2014-09-22 4:38 ` Bhuvanchandra DV
2014-09-19 13:38 ` [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support Bhuvanchandra DV
2014-09-19 16:03 ` Stefan Agner [this message]
2014-09-22 4:49 ` Bhuvanchandra DV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6548345144e6eb9f252bfa35e9783079@agner.ch \
--to=stefan@agner.ch \
--cc=bhuvanchandra.dv@toradex.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome