From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD8AC07E85 for ; Tue, 11 Dec 2018 10:09:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C43120849 for ; Tue, 11 Dec 2018 10:09:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C43120849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726404AbeLKKJU (ORCPT ); Tue, 11 Dec 2018 05:09:20 -0500 Received: from foss.arm.com ([217.140.101.70]:43072 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbeLKKJO (ORCPT ); Tue, 11 Dec 2018 05:09:14 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EAFEF15AD; Tue, 11 Dec 2018 02:09:12 -0800 (PST) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 71C973F59C; Tue, 11 Dec 2018 02:09:09 -0800 (PST) Subject: Re: [PATCH v16 06/16] lib: fdt: add a helper function for handling memory range property To: "AKASHI, Takahiro" , Will Deacon References: <20181115055254.2812-1-takahiro.akashi@linaro.org> <20181115055254.2812-7-takahiro.akashi@linaro.org> <20181206155424.GA4422@arm.com> <681e1265-2f0c-2a62-3778-09911b2be7fc@arm.com> <20181211061715.GF21466@linaro.org> Cc: Rob Herring , Catalin Marinas , David Howells , Vivek Goyal , Herbert Xu , David Miller , dyoung@redhat.com, Baoquan He , Arnd Bergmann , Martin Schwidefsky , Heiko Carstens , prudo@linux.ibm.com, Ard Biesheuvel , bhsharma@redhat.com, kexec@lists.infradead.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , Frank Rowand , devicetree@vger.kernel.org From: James Morse Message-ID: <654bffae-7edb-bda4-d01d-99a8b455b186@arm.com> Date: Tue, 11 Dec 2018 10:09:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181211061715.GF21466@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Akashi, On 11/12/2018 06:17, AKASHI, Takahiro wrote: > On Fri, Dec 07, 2018 at 10:12:47AM +0000, James Morse wrote: >> On 06/12/2018 15:54, Will Deacon wrote: >>> On Thu, Dec 06, 2018 at 08:47:04AM -0600, Rob Herring wrote: >>>> On Wed, Nov 14, 2018 at 11:52 PM AKASHI Takahiro >>>> wrote: >>>>> >>>>> Added function, fdt_setprop_reg(), will be used later to handle >>>>> kexec-specific property in arm64's kexec_file implementation. >>>>> It will possibly be merged into libfdt in the future. >>>> >>>> You generally can't modify libfdt files. Any changes will be blown >>>> away with the next dtc sync (there's one in -next now). Though here >>>> you are creating a new location with fdt code. lib/ is just a shim to >>>> the actual libfdt code. Don't put any implementation there. You can >>>> add this to drivers/of/fdt_address.c for the short term, but it still >>>> needs to go upstream. >>>> >>>> Otherwise, the implementation looks fine to me. >>> >>> I agree, but I don't think there's a real need for us to hack >>> drivers/of/fdt_address.c in the meantime -- let's just target upstream >>> and not carry this in the kernel. >>> >>> Akashi -- for now, I'll drop the kdump parts of this series which rely >>> on this helper. The majority of the series is actually independent and >>> can go in as-is. >>> >>> I've pushed out a kexec branch to the arm64 tree for you to take a look >>> at: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=kexec >> >> I gave this a quick spin. Without the elfcorehdr/usable-memory-range arm64 needs >> to explicitly forbid kdump via kexec_file_load. (like powerpc does already). > > Thank you for pointing this out. > >> Without this kdump works, but the second kernel overwrites the first as those DT >> properties are missing. >> >> I'll post a patch momentarily, > > Fine, but anyhow I'm going to submit a new version (*without* kdump), > I will fix the issue along with others. I had a quick look at the arm64 for-next/core branch. Will has queued the non-kdump parts of this series. If you have changes, they need to be against the arm64 tree. Thanks, James