From: Colin Ian King <colin.king@canonical.com>
To: Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] i2c: xiic: fix indentation issue
Date: Mon, 27 Jan 2020 09:26:21 +0000 [thread overview]
Message-ID: <6558ccbc-56f7-b30d-df02-1eaf07072c4d@canonical.com> (raw)
In-Reply-To: <e20558ec-bf4e-9348-f6cb-a37c5dbbb2de@xilinx.com>
On 27/01/2020 07:43, Michal Simek wrote:
> On 26. 01. 20 16:42, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a statment that is indented one level too deeply, remove
>
> typo ^
Can this be fixed when the patch is applied rather than sending a V2?
Colin
>
>> the extraneous tab.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/i2c/busses/i2c-xiic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
>> index b17d30c9ab40..90c1c362394d 100644
>> --- a/drivers/i2c/busses/i2c-xiic.c
>> +++ b/drivers/i2c/busses/i2c-xiic.c
>> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
>> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
>> if (time_after(jiffies, timeout)) {
>> dev_err(i2c->dev, "Failed to clear rx fifo\n");
>> - return -ETIMEDOUT;
>> + return -ETIMEDOUT;
>> }
>> }
>
> When fixed.
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
>
>
>
>
>
>
next prev parent reply other threads:[~2020-01-27 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 15:42 Colin King
2020-01-27 7:43 ` Michal Simek
2020-01-27 9:26 ` Colin Ian King [this message]
2020-01-27 10:08 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6558ccbc-56f7-b30d-df02-1eaf07072c4d@canonical.com \
--to=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®