From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6662B309DB5 for ; Wed, 4 Mar 2026 07:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772608630; cv=none; b=JQUKbvSGRa+a+r+IMDk6cRDlpP1yx2xHt34y1NfrIGuyRpmkhId5BSB5jAdSKJZSO/qco4FzkYc1kHfjfLfEA2JN++Z6zkErtIvomvisehQUopBStgPEuzrOWACz9sSVLiFZq/FsLUYR/QPaZUy5Xby8LEA0sj1Bxb1/Qm9nm3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772608630; c=relaxed/simple; bh=y9y5rZt6osFsgO0kktoPB9ZSd8wFxoGCLYc1/ZbCDVk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EtmbW/HMJSk5bjwg7djzz8BKVIfFzX17WXV6nRyk04K7/GiYklCn1T+gxDqpBxaANLcqcrMsvLQJrAVoX1/Y7ae2xR3zVPOil8qOMsO0RPDgPnw1/emeumJgUUP77RWXJJxwNINOWTH9/hN2OzVO3bx6ON0R2Jn986YuyzfngAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=yg9bSYkr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=NQCGCIgB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=yg9bSYkr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=NQCGCIgB; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="yg9bSYkr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="NQCGCIgB"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="yg9bSYkr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="NQCGCIgB" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 591683E84E; Wed, 4 Mar 2026 07:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772608624; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2iGl6mqxcn65GDFAjH3OxbirgOiR+EQup6fNmIB7y+k=; b=yg9bSYkrBPiHKTep63OepIt0SxIrypLaIF2GmYDCY+2SBFOI04ac3KPZDNh2+4JNEaLy/f TNAhF2vfqchGpOUJSbWTq/LwBg3YhqUk9WYymkdeZYIGRyAK7hyZZ79zH09OdLjdc+1nRK W1e8IqHCtwSW+48BQo88uNTT8FdbgVU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772608624; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2iGl6mqxcn65GDFAjH3OxbirgOiR+EQup6fNmIB7y+k=; b=NQCGCIgBPGPu0frHX1K3ba1Axta9IcWUKCkVXtboo3jbW6I+Lf6KlgTVoFy6q/2TuD4Ymc o4qHbovzXzbGTPDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=yg9bSYkr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NQCGCIgB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772608624; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2iGl6mqxcn65GDFAjH3OxbirgOiR+EQup6fNmIB7y+k=; b=yg9bSYkrBPiHKTep63OepIt0SxIrypLaIF2GmYDCY+2SBFOI04ac3KPZDNh2+4JNEaLy/f TNAhF2vfqchGpOUJSbWTq/LwBg3YhqUk9WYymkdeZYIGRyAK7hyZZ79zH09OdLjdc+1nRK W1e8IqHCtwSW+48BQo88uNTT8FdbgVU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772608624; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2iGl6mqxcn65GDFAjH3OxbirgOiR+EQup6fNmIB7y+k=; b=NQCGCIgBPGPu0frHX1K3ba1Axta9IcWUKCkVXtboo3jbW6I+Lf6KlgTVoFy6q/2TuD4Ymc o4qHbovzXzbGTPDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 15CE63EA69; Wed, 4 Mar 2026 07:17:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mcGGA3Dcp2ndQQAAD6G6ig (envelope-from ); Wed, 04 Mar 2026 07:17:04 +0000 Message-ID: <655d293e-51ce-4e24-93d1-587480d0680f@suse.de> Date: Wed, 4 Mar 2026 08:17:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] nvme-auth: Don't log shared secret in nvme_auth_dhchap_exponential() To: Thorsten Blum , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: stable@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260303190350.78705-2-thorsten.blum@linux.dev> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260303190350.78705-2-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 591683E84E On 3/3/26 20:03, Thorsten Blum wrote: > When debug logging is enabled, nvme_auth_dhchap_exponential() logs the > DHCHAP shared secret. Remove the log to avoid exposing key material. > > Fixes: b61775d185a3 ("nvme-auth: Diffie-Hellman key exchange support") > Cc: stable@vger.kernel.org > Signed-off-by: Thorsten Blum > --- > drivers/nvme/host/auth.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c > index 405e7c03b1cf..5e4df2ac3cc0 100644 > --- a/drivers/nvme/host/auth.c > +++ b/drivers/nvme/host/auth.c > @@ -655,8 +655,6 @@ static int nvme_auth_dhchap_exponential(struct nvme_ctrl *ctrl, > chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD; > return ret; > } > - dev_dbg(ctrl->device, "shared secret %*ph\n", > - (int)chap->sess_key_len, chap->sess_key); > return 0; > } > Yeah, that was primarily for debugging. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich