From: "Liao, Chang" <liaochang1@huawei.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <rafael@kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: Fix inconsistency in error messages of cpufreq_resume/suspend()
Date: Tue, 29 Aug 2023 14:22:14 +0800 [thread overview]
Message-ID: <655f122b-2c27-0629-15da-7a60348a6ddf@huawei.com> (raw)
In-Reply-To: <20230829060129.ux7lbf22t225necx@vireshk-i7>
在 2023/8/29 14:01, Viresh Kumar 写道:
> On 28-08-23, 20:31, Liao, Chang wrote:
>> What about printing message like this below when cpufreq_start_governor() fails.
>>
>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
>> index 50bbc969ffe5..b78b509429a6 100644
>> --- a/drivers/cpufreq/cpufreq.c
>> +++ b/drivers/cpufreq/cpufreq.c
>> @@ -1943,16 +1943,16 @@ void cpufreq_resume(void)
>>
>> if (ret)
>> - pr_err("%s: Failed to start governor for policy: %p\n",
>> - __func__, policy);
>> + pr_err("%s: Failed to start governor for policy%u\n",
>
> s/policy/CPU%u's policy/ ?
Sounds good, thanks.
--
BR
Liao, Chang
prev parent reply other threads:[~2023-08-29 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 9:52 Liao Chang
2023-08-28 7:00 ` Viresh Kumar
2023-08-28 12:31 ` Liao, Chang
2023-08-29 6:01 ` Viresh Kumar
2023-08-29 6:22 ` Liao, Chang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=655f122b-2c27-0629-15da-7a60348a6ddf@huawei.com \
--to=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®