From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Atul Gupta <atul.gupta@chelsio.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Casey Leedom <leedom@chelsio.com>,
Michael Werner <werner@chelsio.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] cxgb4: prevent potential integer overflow on 32bit
Date: Tue, 10 Dec 2024 12:18:11 +0300 [thread overview]
Message-ID: <65603cba-eeaa-41ef-8d62-3453f3d19c7b@stanley.mountain> (raw)
In-Reply-To: <20241209185556.GA2367494@nvidia.com>
On Mon, Dec 09, 2024 at 02:55:56PM -0400, Jason Gunthorpe wrote:
> On Sat, Nov 30, 2024 at 01:01:37PM +0300, Dan Carpenter wrote:
> > The "gl->tot_len" variable is controlled by the user. It comes from
> > process_responses(). On 32bit systems, the "gl->tot_len +
> > sizeof(struct cpl_pass_accept_req) + sizeof(struct rss_header)" addition
> > could have an integer wrapping bug. Use size_add() to prevent this.
> >
> > Fixes: a08943947873 ("crypto: chtls - Register chtls with net tls")
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> > ---
> > This is from static analysis. I've spent some time reviewing this code
> > but I might be wrong.
>
> Applied to for-next
>
> I fixed the Fixes line:
>
> Fixes: 1cab775c3e75 ("RDMA/cxgb4: Fix LE hash collision bug for passive open connection")
Aw crud. There are two implementations of copy_gl_to_skb_pkt() and I
only patched one. It's pretty weird how I mixed up the Fixes tags.
Anyway, I'll patch drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
as well.
regards,
dan carpenter
prev parent reply other threads:[~2024-12-10 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 10:01 Dan Carpenter
2024-12-09 18:55 ` Jason Gunthorpe
2024-12-10 9:18 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65603cba-eeaa-41ef-8d62-3453f3d19c7b@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=atul.gupta@chelsio.com \
--cc=bharat@chelsio.com \
--cc=davem@davemloft.net \
--cc=jgg@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leedom@chelsio.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=werner@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®