From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99EDB3890ED for ; Tue, 24 Mar 2026 17:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774374106; cv=none; b=GSbFj2Od2YBl/gNA3LmRyRPliEBXfW44OEsC0VOABeXiPr2TZYoGJ5D11kVMcsO8uWAJsJ6wOhdqYskXybQwL0rM4inoI7F5UolA5jEhAEr1eFO03q+K66jRBGvOQNMtoCbFPmf7tSVyeZ9JpGJmRHnXAlH8ao6iTfd9IHG6b/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774374106; c=relaxed/simple; bh=5wqAQ0bTJmsAKt8oyR53qxfzZ+5Wdt4sMMgNx4PqjDk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cvriFSzXzlop7LE7UUcx7GFGZ1lqoTj6AJ4ATZCHPaP4tSAosCXqxEd8GaKRJl884c77Hy0FZgsat6xSY6z3IMEvVqvt04GTit9Ahja0VEyt4IgbT6s2HFWVVJIWTk5gaD5xGJm7hqIsRlM7VrYFjNBWwaCGoG0S/iDJ2aYz0MU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=L0PVfg8f; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="L0PVfg8f" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-46808125d28so997395b6e.1 for ; Tue, 24 Mar 2026 10:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1774374103; x=1774978903; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SZS7sCjvuHhpivHZjRZo+N6jfKc3vOgopKpbJzsd0MA=; b=L0PVfg8fx9/1/NUOWjvpWa7CgNqrMh8jg0bF2R1oXn7uZKLMgcNzyJRHpYyPm166AR 9iRatxgNA1sTwc5nX0qpZXM5Q+pSQj5HCZsG3LJRf8U68nnAQmbTNEbBqSstqoYgwpxz 3IuMcJMKk/GoA9Le8b9TfA9SUmkQD9wY7g9os= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774374103; x=1774978903; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SZS7sCjvuHhpivHZjRZo+N6jfKc3vOgopKpbJzsd0MA=; b=acrDGQl7+EKmzm4lQM2AaahyG3leLzImYIl3q6CZeYH1Wd5b7/qsSCHNZ/wxf2A/iZ rEOv/nKP7d48vGSTr4LmWPMldEU8E2Bb+Pz+7NrbFi9Eytf8df4PLu67NDR+Pp76pgH4 6RSyJHAnp+Xx8TY2LTP3QZPf/r+nw0937izmkoXmai/jkdx1/sDMPdpj92VzCKlFzrYK vgWujscPV8YnzAUfyvRzHtJXC/+/CcurHRKSfZGnrlv1FR9R/S57sA7Ezw2xD2/pySxC +Nvn2az6l/6ZCvKTseqelnPPVp3ielXpGX3I7Yy+nFr8P2xJ8O+wUIafqbgi0R37ST1F I/Gw== X-Forwarded-Encrypted: i=1; AJvYcCVh7b4AkVI40j5+UXJw7E0SWWcfRtTI4nlFMatGkqDV0ieYlnwHpWYgaFREN+G5YWUpx35kvkHto7QfeQQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxjDiNGU9HGu6QAK36OozQlHJSs4EZveCLsv7ZCx2uFF859eeul gcWr2hiBR/yiPzKo01gmwDdHoZLiNY6YDs8rVIF50+CHzhiBf7FBX0cNoTJLbpxZ2z8= X-Gm-Gg: ATEYQzzz5TV0gdLPJHsp/Ua6EqSQV6x9RWZs+zRQSf9p6LH+HPjL0v/KFcUtPf3B2Zv IshCGwHRX2sHkCfQRL2tcz+Y+0JkiqTt3H6PNVPkefnLZAwzSkohHAW40YRLNCZXOcYIrxTf/Nm 0F7xdFrdJVDaAPt8jp4B/VIgnTm1O5HzR9HS0QoG/FWG4IVUy4KFnYXANkRiSERAU6Y4u3MaiaF kmvSastEybIfj8ZnyoXPnWmaQSfzhb927tXAoOcODRuoOcjzA5WnR4sXv0CempvBjwPU/R9Fpfq rT8j7zEcSwy52/PtYC2ts7/f6ir5iJZELdWuOJE8xre1n9zQDI0d1cHqHOYcfuQzcB13xgDX3w/ Ux9uFOOIU0OnmESVPXDIUCe4D90e3qmfE5jkzWv3MFh0gD/Zd6DvqWC7bQEP3WSYEDaTnKURnF2 vipc4PazxWOtATgTTGdu+lsZ+Gc/Sdav+AoFc= X-Received: by 2002:a05:6808:1b1e:b0:45c:8f03:1e19 with SMTP id 5614622812f47-46a5c7bfdddmr220230b6e.55.1774374103477; Tue, 24 Mar 2026 10:41:43 -0700 (PDT) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 5614622812f47-467e7d18ad3sm9498867b6e.1.2026.03.24.10.41.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 10:41:43 -0700 (PDT) Message-ID: <656d3bf5-8d97-454e-9691-540cdb79dab4@linuxfoundation.org> Date: Tue, 24 Mar 2026 11:41:40 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings To: Prithvi , Andy Shevchenko Cc: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, straube.linux@gmail.com, b9788213@gmail.com, ethantidmore06@gmail.com, dan.carpenter@linaro.org, weibu@redadmin.org, knavaneeth786@gmail.com, ignacio.pena87@gmail.com, dharanitharan725@gmail.com, lukagejak5@gmail.com, samasth.norway.ananda@oracle.com, karanja99erick@gmail.com, s9430939@naver.com, suunj1331@gmail.com, ysinghcin@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, khalid@kernel.org, Shuah Khan References: <20260323162901.121947-1-activprithvi@gmail.com> <20260324130234.3776tp4ykuerffcg@inspiron> <20260324135551.grth7jfjyoh5krzr@inspiron> <20260324160229.f46h25ebd2mxcfiq@inspiron> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260324160229.f46h25ebd2mxcfiq@inspiron> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/24/26 10:02, Prithvi wrote: > On Tue, Mar 24, 2026 at 04:05:51PM +0200, Andy Shevchenko wrote: >> On Tue, Mar 24, 2026 at 07:25:51PM +0530, Prithvi wrote: >>> Sure. Also can you please guide if any testing would be required for these >>> changes, or I can directly send the v3 patch? >> >> It's implied that the author of the patch each time before submission (either >> a new version of the existing patch or a new patch in general) is tested and >> validated it. +1 >> >> -- >> With Best Regards, >> Andy Shevchenko >> >> > > Understood. I agree that patch must be tested and validated every time. > > To be transparent, I do not have access to the physical Realtek hardware, > so I am unable to perform runtime testing. However, for this v3, I have > performed compile testing and ensured that the module builds correctly. > Will this be acceptable for this patch? No - Hmm. Aren't you part of Fall mentorship program? We discussed this several times during the program that when someone sends a patch, it is implied that they tested the patch. Compile testing isn't sufficient. The changes in this patch not trivial spelling fixes in comments either. - if (1 <= channel && channel <= 14) { + if (channel >= 1 && channel <= 14) { I picked just one and there are more like this one. These aren't just moving the constant lies to the right side of the test, they change logic and in some cases removing the code and the change log doesn't say anything about that. Did you look into if this conditional can just go away? - if (0x00 == PathAOK) { - } I am not the maintainer for this, but as your mentor this isn't acceptable. I wouldn't take this patch unless these changes are tested on the device. thanks, -- Shuah