Re: [PATCH v4 2/3] Input: add ABS_SND_PROFILE

[Caleb Connolly <caleb@connolly.tech>]

On 07/04/2023 18:11, Bjorn Andersson wrote:
> On Wed, Feb 22, 2023 at 01:10:33AM +0100, Gergo Koteles wrote:
>> ABS_SND_PROFILE used to describe the state of a multi-value sound profile
>> switch. This will be used for the alert-slider on OnePlus phones or other
>> phones.
>>
>> Profile values added as SND_PROFLE_(SILENT|VIBRATE|RING) identifiers
>> to input-event-codes.h so they can be used from DTS.
>>
>> Signed-off-by: Gergo Koteles <soyer@irl.hu>
>> ---
>>  Documentation/input/event-codes.rst    | 6 ++++++
>>  drivers/hid/hid-debug.c                | 1 +
>>  include/uapi/linux/input-event-codes.h | 9 +++++++++
>>  3 files changed, 16 insertions(+)
>>
>> diff --git a/Documentation/input/event-codes.rst b/Documentation/input/event-codes.rst
>> index b4557462edd7..d43336e64d6a 100644
>> --- a/Documentation/input/event-codes.rst
>> +++ b/Documentation/input/event-codes.rst
>> @@ -241,6 +241,12 @@ A few EV_ABS codes have special meanings:
>>      emitted only when the selected profile changes, indicating the newly
>>      selected profile value.
>>
...
>>
>> +/*
>> + * ABS_SND_PROFILE values
>> + */
>> +
>> +#define SND_PROFILE_SILENT	0x00
>> +#define SND_PROFILE_VIBRATE	0x01
>> +#define SND_PROFILE_RING	0x02
> 
> The patch looks good to me, bu I'd need these header file additions in
> order to merge the dts patch. Could I get an ack and take it through the
> Qualocmm tree, or could you pick it up for 6.4, and then I can merge the
> dts change after that?

Bump, I think this might have gotten lost.
> 
> Regards,
> Bjorn
> 
>> +
>>  #endif
>> --
>> 2.39.2
>>

-- 
Kind Regards,
Caleb