From: Song Liu <songliubraving@fb.com>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: perf tools: remove option --tail-synthesize ?
Date: Thu, 22 Nov 2018 18:18:15 +0000 [thread overview]
Message-ID: <65755121-AC25-424E-8218-A755A084A1AF@fb.com> (raw)
In-Reply-To: <da87afd6-c291-2049-5e0b-a02512122806@huawei.com>
> On Nov 21, 2018, at 5:50 PM, Wangnan (F) <wangnan0@huawei.com> wrote:
>
>
>
> On 2018/11/21 21:11, Arnaldo Carvalho de Melo wrote:
>> Em Wed, Nov 21, 2018 at 07:45:28AM +0000, Song Liu escreveu:
>>> Hi,
>>>
>>> I found perf-record --tail-synthesize without --overwrite breaks symbols
>>> for perf-script, perf-report, etc. For example:
>>>
>>> [root@]# ~/perf record -ag --tail-synthesize -- sleep 1
>>> [ perf record: Woken up 1 times to write data ]
>>> [ perf record: Captured and wrote 1.129 MB perf.data (3531 samples) ]
>>> [root@]# ~/perf script | head
>>> swapper 0 [000] 1250675.051971: 1 cycles:ppp:
>>> ffffffff81009e15 [unknown] ([unknown])
>>> ffffffff81196b19 [unknown] ([unknown])
>>> ffffffff81196579 [unknown] ([unknown])
>>> ffffffff81110ca7 [unknown] ([unknown])
>>> ffffffff81a01f4a [unknown] ([unknown])
>>> ffffffff81a017bf [unknown] ([unknown])
>>> ffffffff8180e17a [unknown] ([unknown])
>>>
>>> perf-record with --overwrite does NOT have this issue.
>>>
>>> After digging into this, I found this issue is introduced by commit
>>> a73e24d240bc136619d382b1268f34d75c9d25ce.
>>>
>>> Reverting this commit does fix this issue. However, on a second thought,
>>> I feel it is probably better just drop --tail-synthesize, as it doesn't
>>> make much sense without --overwrite. All we need is to do tail_synthesize
>>> when --overwrite is set.
>>>
>
> Some cases we use --overwrite without --tail-synthesize. How about setting
> --tail-synthesize when selecting --overwrite by default, throw a warning
> when --overwrite is not set and leave a --no-tail-synthesize option?
>
--overwrite implies --tail-synthesize. So with --overwrite, it is always
tail-synthesize. Do we really need --overwrite and --no-tail-synthesize?
If not, we can probably just drop --tail-synthesize (or mark it as
deprecated)?
Thanks,
Song
prev parent reply other threads:[~2018-11-22 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 7:45 Song Liu
2018-11-21 10:47 ` Jiri Olsa
2018-11-21 17:56 ` Song Liu
2018-11-21 13:11 ` Arnaldo Carvalho de Melo
2018-11-22 1:50 ` Wangnan (F)
2018-11-22 9:03 ` Jiri Olsa
2018-11-22 18:18 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65755121-AC25-424E-8218-A755A084A1AF@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®