From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>, Dan Murphy <dmurphy@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v8 2/2] leds: lm3601x: Introduce the lm3601x LED driver
Date: Tue, 22 May 2018 22:58:12 +0200 [thread overview]
Message-ID: <6577f2f9-7a31-3b98-71e2-2f86818eac7a@gmail.com> (raw)
In-Reply-To: <CAHp75Vdg9HTyQhv1KMOCqq5FjgPAC2q015Opnh3jDWvZY2bbNQ@mail.gmail.com>
On 05/22/2018 10:34 PM, Andy Shevchenko wrote:
> On Tue, May 22, 2018 at 11:26 PM, Dan Murphy <dmurphy@ti.com> wrote:
>> On 05/22/2018 03:12 PM, Andy Shevchenko wrote:
>>> On Tue, May 22, 2018 at 5:24 PM, Dan Murphy <dmurphy@ti.com> wrote:
>
>
>>>> +static struct lm3601x_led *fled_cdev_to_led(
>>>> + struct led_classdev_flash *fled_cdev)
>>>
>>> Didn't notice before. This will look much better in one line.
>>
>> Gives LTL warning.
>
> I wouldn't really care about it.
> But I leave to Jacek to decide.
Please make it one line.
It is even Linus' recommendation to not strictly stick to the
80 character limit as we all have modern computers nowadays.
> After addressing the rest, FWIW,
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2018-05-22 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 14:24 [PATCH v8 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Dan Murphy
2018-05-22 14:24 ` [PATCH v8 2/2] leds: lm3601x: Introduce the lm3601x LED driver Dan Murphy
2018-05-22 20:12 ` Andy Shevchenko
2018-05-22 20:26 ` Dan Murphy
2018-05-22 20:34 ` Andy Shevchenko
2018-05-22 20:58 ` Jacek Anaszewski [this message]
2018-05-22 20:53 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6577f2f9-7a31-3b98-71e2-2f86818eac7a@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®