mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dingxian Wen <shawn.wen@rock-chips.com>,
	Shreeya Patel <shreeya.patel@collabora.com>
Cc: Gerald Loacker <gerald.loacker@wolfvision.net>,
	Lucas Sinn <lucas.sinn@wolfvision.net>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	kernel@collabora.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/10] media: synopsys: hdmirx: add media device infrastructure
Date: Wed, 4 Nov 2026 17:11:25 +0300	[thread overview]
Message-ID: <657ea8a3-2cfd-4c90-b672-84c78acee181@collabora.com> (raw)
In-Reply-To: <20261005-hdmirx-media-v3-2-71a11a2e3e76@pengutronix.de>

On 10/5/26 16:28, Sascha Hauer wrote:
> From: Gerald Loacker <gerald.loacker@wolfvision.net>
> 
> Initialize the media device to enable integration with HDMI bridge
> devices in the video capture pipeline. This provides the foundation
> for representing the hardware topology through the media controller
> framework.
> 
> Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>   drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> index bc541431638e7..8b04c84be75ec 100644
> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -31,6 +31,7 @@
>   #include <linux/workqueue.h>
>   
>   #include <media/cec.h>
> +#include <media/media-device.h>
>   #include <media/v4l2-common.h>
>   #include <media/v4l2-ctrls.h>
>   #include <media/v4l2-device.h>
> @@ -123,6 +124,7 @@ struct snps_hdmirx_dev {
>   	struct device *dev;
>   	struct hdmirx_stream stream;
>   	struct v4l2_device v4l2_dev;
> +	struct media_device mdev;
>   	struct v4l2_ctrl_handler hdl;
>   	struct v4l2_ctrl *detect_tx_5v_ctrl;
>   	struct v4l2_ctrl *rgb_range;
> @@ -2649,6 +2651,7 @@ static void hdmirx_v4l2_release(struct v4l2_device *v4l2_dev)
>   		container_of(v4l2_dev, struct snps_hdmirx_dev, v4l2_dev);
>   
>   	v4l2_ctrl_handler_free(&hdmirx_dev->hdl);
> +	media_device_cleanup(&hdmirx_dev->mdev);
>   	kfree(hdmirx_dev);
>   }
>   
> @@ -2751,6 +2754,11 @@ static int hdmirx_probe(struct platform_device *pdev)
>   		goto err_pm;
>   	}
>   
> +	hdmirx_dev->mdev.dev = dev;
> +	strscpy(hdmirx_dev->mdev.model, "snps-hdmirx", sizeof(hdmirx_dev->mdev.model));
> +	media_device_init(&hdmirx_dev->mdev);
> +	hdmirx_dev->v4l2_dev.mdev = &hdmirx_dev->mdev;
> +
>   	stream = &hdmirx_dev->stream;
>   	stream->hdmirx_dev = hdmirx_dev;
>   	ret = hdmirx_register_stream_vdev(stream);
> 

Acked-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

-- 
Best regards,
Dmitry

  reply	other threads:[~2026-11-04 14:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 13:28 [PATCH v3 00/10] media: synopsys: hdmirx: support an HDMI bridge in front of the receiver Sascha Hauer
2026-10-05 13:28 ` [PATCH v3 01/10] media: synopsys: hdmirx: free the driver data when the last user is gone Sascha Hauer
2026-10-07 11:20   ` Dmitry Osipenko
2026-10-16 11:06     ` Sascha Hauer
2026-11-04 14:18       ` Dmitry Osipenko
2026-10-05 13:28 ` [PATCH v3 02/10] media: synopsys: hdmirx: add media device infrastructure Sascha Hauer
2026-11-04 14:11   ` Dmitry Osipenko [this message]
2026-10-05 13:28 ` [PATCH v3 03/10] media: synopsys: hdmirx: add media entity for video capture device Sascha Hauer
2026-11-04 14:11   ` Dmitry Osipenko
2026-10-05 13:28 ` [PATCH v3 04/10] dt-bindings: media: snps,dw-hdmi-rx: add a port for a bridge in front Sascha Hauer
2026-11-04 14:11   ` Dmitry Osipenko
2026-11-04 14:12   ` Dmitry Osipenko
2026-10-05 13:28 ` [PATCH v3 05/10] media: synopsys: hdmirx: add async subdevice support Sascha Hauer
2026-11-04 14:12   ` Dmitry Osipenko
2026-10-05 13:28 ` [PATCH v3 06/10] media: synopsys: hdmirx: give the signal lock wait a real timeout Sascha Hauer
2026-11-04 14:12   ` Dmitry Osipenko
2026-10-05 13:28 ` [PATCH v3 07/10] media: synopsys: hdmirx: skip the 5V detect interrupt without a GPIO Sascha Hauer
2026-11-04 14:12   ` Dmitry Osipenko
2026-10-05 13:28 ` [PATCH v3 08/10] media: v4l2-device: wait for notifications when unregistering a subdev Sascha Hauer
2026-10-05 13:28 ` [PATCH v3 09/10] media: v4l2-subdev: notify the bridge when the source power changes Sascha Hauer
2026-10-05 13:28 ` [PATCH v3 10/10] media: synopsys: hdmirx: get the 5V state from the upstream subdev Sascha Hauer
2026-11-04 14:12   ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=657ea8a3-2cfd-4c90-b672-84c78acee181@collabora.com \
    --to=dmitry.osipenko@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gerald.loacker@wolfvision.net \
    --cc=hverkuil@kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lucas.sinn@wolfvision.net \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.wen@rock-chips.com \
    --cc=shreeya.patel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®