From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8FA2C4361B for ; Tue, 15 Dec 2020 08:42:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E3A620855 for ; Tue, 15 Dec 2020 08:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727567AbgLOImV (ORCPT ); Tue, 15 Dec 2020 03:42:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726883AbgLOImC (ORCPT ); Tue, 15 Dec 2020 03:42:02 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D26F4C06179C for ; Tue, 15 Dec 2020 00:41:21 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id w5so15238464wrm.11 for ; Tue, 15 Dec 2020 00:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GbEzlI33OGU2m93piMSf4kBL+lR5zxOJKf2VeMLoEIE=; b=yCuexCqgQRrHyuPvGukIq9TNU/xW0HW9gQQ3S8iCnSnrXJYAl925lc9udtiq/mYlf9 AQzIl6bb1OCTt/r39DssvnP/xtSQLc9HhcU3kVE6fiqHFemMiM5/jvIdK+vAXZOZttUh 9AEdnJ2P0COYe/9b6MYcwZEWVDKwJF1EL76vqi/5IBaSkNK9QwbFDqzn9ToR1OX3J3+O efJ6mcmgAi2+Cjk12dwpgZz03VHQiN+QXfIyQxT4Tz+FBrx8kVfsLkIVEG+flcSYH92e R5ZGI95tV1tCw/hz9kSRxAnBrJ5tquJn1EUdGE9ANCC+dcdz6NTn9xt1CkdPqb3OB1WD JOmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GbEzlI33OGU2m93piMSf4kBL+lR5zxOJKf2VeMLoEIE=; b=ETOZB9Bium20qYptThIutF9AqE1Iuhk+b2iJUFuEJXliN2s4Xg6En+I2yVJK6ECUOw wOHcnK6qJ1IvYVoicKc/JpP1tGZ5P6I2XGSbE/BrhzmSkmP0rwVqK92uCMpsDgcG77h/ 5bZn7bZo1eZ8J6zl0w4pBwHFCXuo9KT4lh4o5daNopMdvmF8s666uoW/71wHGD2V+INu N2nnq08KtlDRPfPDgiWT6ExuViJPyV2W/t7xv052UdFaoXjnuOtTr57N22MAVGYoS8jA CNtLoxXlxBYrIOWtn6H9cZnSrRJDVeXETxkx1jpjzWmO/olLTr2vUKNB0dlA4PBnmGr2 BTTg== X-Gm-Message-State: AOAM530qjEByxRfOAuPvBi6xiMkI/HTgNdVWX3Zcu4adHdpH7mkWJaP/ bUgJUQPy6XBiE9y+5g0vKigWYw== X-Google-Smtp-Source: ABdhPJzBNEtjk59mcpfwSNW8Qzw6ooxHFo5FWxuFpo6rL/Za+fg5OV/zUyaEaZ0WNX4Z4qYdYvXKGw== X-Received: by 2002:a5d:4bc2:: with SMTP id l2mr17095662wrt.204.1608021680445; Tue, 15 Dec 2020 00:41:20 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:e842:4086:6f24:55a6? ([2a01:e34:ed2f:f020:e842:4086:6f24:55a6]) by smtp.googlemail.com with ESMTPSA id l16sm37134641wrx.5.2020.12.15.00.41.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 00:41:19 -0800 (PST) Subject: Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model To: rui.zhang@intel.com, lukasz.luba@arm.com Cc: sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Arnd Bergmann References: <20201215125806.31495950@canb.auug.org.au> <20201215083520.601988-1-daniel.lezcano@linaro.org> From: Daniel Lezcano Message-ID: <657f28a7-fc75-06ae-a96c-d2ef0485e4bc@linaro.org> Date: Tue, 15 Dec 2020 09:41:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201215083520.601988-1-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A separate patch should add the select ENERGY_MODEL in the multi_v7_defconfig so the devfreq cooling device continues to build by default as before. Arnd? On 15/12/2020 09:35, Daniel Lezcano wrote: > The devfreq cooling device has been converted to use the energy model. > > Add the dependency on the ENERGY_MODEL option to reflect this change > and prevent build failure if the option is not set. > > Fixes: 615510fe13bd2 ("thermal: devfreq_cooling: remove old power model and use EM") > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 7edc8dc6bbab..ee62d51ef351 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -193,6 +193,7 @@ config DEVFREQ_THERMAL > bool "Generic device cooling support" > depends on PM_DEVFREQ > depends on PM_OPP > + depends on ENERGY_MODEL > help > This implements the generic devfreq cooling mechanism through > frequency reduction for devices using devfreq. > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog