From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996784183D8 for ; Tue, 9 Jun 2026 13:33:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011995; cv=none; b=LDXAMbUsyDpPX+bGZvqjvNFXMXKvwBhXjpC49uqO8oSfcec1shSBen6pRXkuiiRS0iEYLSwalnmA4Nw2QgBa2jH1Xm2mwcHGBjLftLorbg5SRH8GAnElMHLx8ZxtV4n8F/0oumaMIYfW/o7x8mwr5oidd9Q2HH+rFxb/iRSMmlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011995; c=relaxed/simple; bh=288anrzOO9rcBt1V1M5l8ZmKbaxYiWXZtCin4Usp3Ac=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dJq/j+VB9t0oOkrLnSkSpQF4Soqhu0+BG0lxH2BJhImVGQKn+7cIssR7p9rfJIQMweXH6Zbb4SWdVDWKUbKq/jTHogzMvFk3iKKMbG7ytE3V4sdNy5UORU8j1amrjQ3SQlVU6u8WwaR4p92joGDndjzKFE0FK5+HvMs6pohH19g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GMN71wpZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I2PrNmoU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GMN71wpZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I2PrNmoU" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659CmRxo2625141 for ; Tue, 9 Jun 2026 13:33:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sBxQ4GzhBRGOBHg0hs0l0twx3c3nO6bk1aAIhzyg3F0=; b=GMN71wpZR9byAdwR nucKCj3oO7n2bvEb4k3LeIrMVQ3Sg85idBWtpk++OpSIXEdjX0zcG7ILbOL1uycR XCuyJUfjU4uTv73q5pV09jmMSWsMa/A2+zceJ/UGKFK7A344P/uaD9QknlRZMcx3 HM4KVGCg07cqPtO/2abMadx3xFGLfZwAnJgn1+e/40lSGSmjQhJ5i9v0EwwIxq3V 8FhR3nw8ZZUoXdTog245AQjyXcxcbJsfNx4vpvV+wUhrbyAPcX394yWZz3bkzRxc 73Yct+C+aOLeGjXsiLA2iBq8hREfo7fwNIW84HyB1GeK9mxpMvfvEaA8d72qIIip yDwrcA== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epdds9vjy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 13:33:12 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-59eb436e77cso341113e0c.0 for ; Tue, 09 Jun 2026 06:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781011992; x=1781616792; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sBxQ4GzhBRGOBHg0hs0l0twx3c3nO6bk1aAIhzyg3F0=; b=I2PrNmoUYu1q6cTJ3ra56/FMuPBAIKDWsAv/wfgaF3UD6FO6zeRZVv6Q6sdqMevk5D 3ZztP833SznnYIbbmZpDoFcfs0xh0KwP/EFEyE345p1+SXq0EDGg4ho/D66v0JjV1qVg 1h0vi78MIMx7/HwtrBlohzW7xzQgJCG6oN1qmzfPOlY1cNR7rqD2hgVSCkwD/MVVJCMu QMs4wJ0GXgPkF3rBADm/F7Xfi/19mQP3+ssaIeIWdnIUzk9rxitUsEAMfMsefUGS1f/C fOl8MQ6ClfZGQiwMasa+aXmuq0tsSr2DrUEjEnFGN0Hg+Sbr6G5PtEeHJujf9Lvcdfzj cWiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781011992; x=1781616792; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sBxQ4GzhBRGOBHg0hs0l0twx3c3nO6bk1aAIhzyg3F0=; b=MXoxrNdZyb5mQEwLNWleF+StCDGpaqkZ6LujSnYX4IDJaQss06f2pJbNhUvrSo89dP f9ZnZtmrEhsDoS7xpq93HPbOrJQf1+6CKWwIxxqyXv7rQLGYWdEpd+eA1k2dkCAMHaLP DVxa9/7dbpdpu9Ac2+/A1kkqSpnRBgElkFXq+DojEYjibiG2y55Tg12tjSeKt6DueKST la5xOqkGzI0lFMcVg2ztIimFY7ls8j7gb7eaj+pXF7jsCMf+4GcMT2+KmxTjvMJL44oh vwIDPuDYgIh/kLgoGv+tuKhbyE1+JsA3mVytYdOCayuIOXn1ED7t4ilpyphAxIMLnd0y MDvg== X-Forwarded-Encrypted: i=1; AFNElJ9qORqJYfFs1eaXYAofPAxK1zfxdRJjyz8xDM1ZD3xd50PClD4g4vHzYMGMupeupj+fsCk+XfgQivPKRxw=@vger.kernel.org X-Gm-Message-State: AOJu0YyfinIZNRRSTAcQuIE6SjXV7x+2oRtQMCiIUn+ZSRUH8xCnsHU6 U05kyJChjbUebIOaXLHhP+z28QKhIvIu4Svj9zgOdWBQ+TCNXk/5t4T8bg1amtF70PWbGSwBJP1 mbdZBO/vwx04b2hYZZByKt/tEGomLoy0rtdacy5ijNbI2wVqIZHNFKoq+n4v52s2/AcA= X-Gm-Gg: Acq92OHEZcaGOkWmBdDlKGfE2a+bUXQMx7HW1aL2Ta22koDPg2HJUJS8AQLuPBBB7UT yptUx5AALqm90iH+WROH+vq+jJnefrnm8yNeK2imd/dJfmG8naD/+bKRhvKV6PglzZwkLXd5OPC /iwRKPZ0jWP9z2Vyv/FnGG+X4s+iy4saJQxjKSO8r1P6MY8LNSEk+mb8+A7a/m8EpfaPAsWk5Ig v4nJpDWs/3jOXPD+1/ZdGxA0PMSARy7fgEFzccNd1wJgEghg6YGNUWBpWZ/7xeai5089uJOueC1 Bf7cW/SUp4dXGSJN/1o8oQXC3gEqD4uqOs6UI5vnO38zRMfxNC28SlduFp+2Afaf64sIph6B2Nq rDKPCcneH8vKuQCZ5WF86Cn3FNp9HFlJI35Tbu5uyq691mB6NZGOdLZms X-Received: by 2002:a05:6102:390f:b0:674:d57b:fcb4 with SMTP id ada2fe7eead31-6fefa607a15mr3062432137.4.1781011991622; Tue, 09 Jun 2026 06:33:11 -0700 (PDT) X-Received: by 2002:a05:6102:390f:b0:674:d57b:fcb4 with SMTP id ada2fe7eead31-6fefa607a15mr3062399137.4.1781011991016; Tue, 09 Jun 2026 06:33:11 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf0559f1aaasm1037486766b.59.2026.06.09.06.33.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 06:33:10 -0700 (PDT) Message-ID: <658358a6-45bb-424e-8d8c-5b0b09cf479d@oss.qualcomm.com> Date: Tue, 9 Jun 2026 15:33:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: glymur: Drop fake PCIe phy 3B To: Krzysztof Kozlowski , Krzysztof Kozlowski , Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260420133616.88740-2-krzysztof.kozlowski@oss.qualcomm.com> <5c1f7955-883f-4fa8-a0e5-513a987bd3a9@oss.qualcomm.com> <0710caaf-ec73-4c4c-b6cb-7fe716724f4b@oss.qualcomm.com> <13349811-31e3-4658-911f-6f93d74efaaa@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <13349811-31e3-4658-911f-6f93d74efaaa@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: XvtIVhJ1QfCgRIhcXHopM1LB-kcafhHu X-Authority-Analysis: v=2.4 cv=EI42FVZC c=1 sm=1 tr=0 ts=6a281618 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=dyzjOPN-2kheIc5eeAEA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-GUID: XvtIVhJ1QfCgRIhcXHopM1LB-kcafhHu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDEyOCBTYWx0ZWRfXwv1rKoWRqlPz /DwLdgV6mn2oGItze3rT/Kdo5MrrhrC02VBtGJ6r1cZj5C/FRsvxSGaf1H3OehHwovyKxkhY3rH aBdhA5l2SyWdg1kcgopnE88GwiQ/Iu21A/IvpQ/lbhnZLC44XwP5P9zhO2FK/4hag1r8m5rgOjX heG4sJ/AjvZU3XByBTNH+byKZ7k6Kz8LeLqIsW1WHa6myb/RyWZfXOlPGF2wl+Wq2RiiVoNOFrN RK2T1kpv+X4uAKqrGOGdYS8v0b1UynaQzWksDNMp2CxX3h9BvdFR1rW05SkRINCY2n3BPFhyU5+ rLrWrU3yMi0fcFFDTmnq2LGaFL027dDqGXRuYJ7kRgGHTU1YmzzDLEYEgKLkNZpxtg7/oxqUzGo OmVP7DUOrAPRptV4nPhoPjSCkuN4ZpDDWKxTnSHou8iN6o0h20WzoC68N3QPaCI/K4i7tCWmoZ3 EfrmWgm/Dfc+BpN/3Tg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090128 On 6/9/26 12:28 PM, Krzysztof Kozlowski wrote: > On 24/04/2026 13:09, Konrad Dybcio wrote: >> On 4/23/26 9:16 AM, Krzysztof Kozlowski wrote: >>> On 22/04/2026 22:08, Dmitry Baryshkov wrote: >>>> On Tue, Apr 21, 2026 at 08:41:14AM +0200, Krzysztof Kozlowski wrote: >>>>> On 20/04/2026 20:02, Dmitry Baryshkov wrote: >>>>>> On Mon, Apr 20, 2026 at 03:36:17PM +0200, Krzysztof Kozlowski wrote: >>>>>>> According to user manual / programming guide there is no separate PCIe >>>>>>> phy 3A and 3B, but one 8-lane QMP PCIe Gen5 PHY which consists of two >>>>>>> 4-lane blocks. This is also visible in memory map, where the 0xf00000 >>>>>>> is marked as the main block with additional sub blocks for each 4-lane >>>>>>> phys. >>>>>>> >>>>>>> Describing the sub phys without the rest is not correct from hardware >>>>>>> description, even if it works. >>>>>> >>>>>> Is this the case for the other bifurcated PHYs? >>>>>> >>>>> >>>>> There's more? Oh damn... >>>> >>>> In the previous generations. I think Hamoa had one. >> >> Any PHY with a name ending in -A or -B. That means: >> >> $ rg 'PCIE_.[AB]_' drivers/clk/qcom/ -l >> drivers/clk/qcom/gcc-x1e80100.c >> drivers/clk/qcom/gcc-glymur.c >> drivers/clk/qcom/gcc-sc8280xp.c >> >> >> And, quite predictably, some PHYs may not only bifurcate, but also >> tri- or quadfurcate (on Nord). >> >>> Ah, I did not check the others and there is little we can do there - >>> it's released DTS. This cannot be easily changed while keeping DTS >>> compatible with users, because probably two PHY nodes will be replaced >>> by one with different compatible. >> >> I think no one utilized the non-reference configuration of those PHYs >> in practice. Should a device like that come around though, we'll think >> about what to do then.. >> > > What is the resolution of this discussion? I have impression that no one > objected to my patch, so maybe I should resend it? Qiang is working on a proper solution to this. PCIe3B is nominally used for a secondary NVMe, so on the occasion that someone has one inserted, this isn't really a huge loss (the Yoga laptop and the CRD both have a primary NVMe on PCIe5 IIRC) Konrad