From: Ira Weiny <ira.weiny@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Vishal Verma <vishal.l.verma@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>, <nvdimm@lists.linux.dev>
Subject: Re: [PATCH 1/3] nvdimm/btt: fix btt_blk_cleanup() kernel-doc
Date: Thu, 21 Dec 2023 14:14:29 -0800 [thread overview]
Message-ID: <6584b8c5999cb_55802294ef@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20231207210545.24056-1-rdunlap@infradead.org>
Randy Dunlap wrote:
> Correct the function parameters to prevent kernel-doc warnings:
>
> btt.c:1567: warning: Function parameter or member 'nd_region' not described in 'btt_init'
> btt.c:1567: warning: Excess function parameter 'maxlane' description in 'btt_init'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Cc: nvdimm@lists.linux.dev
> ---
> drivers/nvdimm/btt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1550,7 +1550,7 @@ static void btt_blk_cleanup(struct btt *
> * @rawsize: raw size in bytes of the backing device
> * @lbasize: lba size of the backing device
> * @uuid: A uuid for the backing device - this is stored on media
> - * @maxlane: maximum number of parallel requests the device can handle
> + * @nd_region: &struct nd_region for the REGION device
> *
> * Initialize a Block Translation Table on a backing device to provide
> * single sector power fail atomicity.
prev parent reply other threads:[~2023-12-21 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 21:05 Randy Dunlap
2023-12-07 21:05 ` [PATCH 2/3] nvdimm/dimm_devs: fix kernel-doc for function params Randy Dunlap
2023-12-21 22:28 ` Ira Weiny
2023-12-21 22:34 ` Ira Weiny
2023-12-21 23:34 ` Randy Dunlap
2023-12-07 21:05 ` [PATCH 3/3] nvdimm/namespace: " Randy Dunlap
2023-12-21 22:32 ` Ira Weiny
2023-12-21 23:26 ` Randy Dunlap
2023-12-21 23:29 ` Ira Weiny
2023-12-21 22:14 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6584b8c5999cb_55802294ef@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rdunlap@infradead.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®