Re: [PATCH v3 1/3] dt-bindings: arm: qcom: Split HP Omnibook X14 AI in SoC variants

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/07/2025 08:59, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> 
> The HP Omnibook X14 AI PC is available in fe0 (Hamoa, x1e80100) and
> fe1 (Purwa, x1p42100) SKUs. Since they are not completely dtb-compatible,
> split the model strings in 2 variants:
> 
> hp,omnibook-x14-fe0 compatible to qcom,x1e80100
> hp,omnibook-x14-fe1 compatible to cqom,x1p42100
> 
> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index ae43b35565808ed27cd8354b9a342545c4a98ed6..d114b7ae4fa7b162a83a152d9bf8d3fc2d74750a 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1148,7 +1148,7 @@ properties:
>                - asus,zenbook-a14-ux3407ra
>                - dell,xps13-9345
>                - hp,elitebook-ultra-g1q
> -              - hp,omnibook-x14

You just added it half a year ago... Anyway, it  is an ABI now, you
cannot drop it.

> +              - hp,omnibook-x14-fe0
>                - lenovo,yoga-slim7x
>                - microsoft,romulus13
>                - microsoft,romulus15
> @@ -1159,6 +1159,7 @@ properties:
>        - items:
>            - enum:
>                - asus,zenbook-a14-ux3407qa
> +              - hp,omnibook-x14-fe1

This part is fine.



Best regards,
Krzysztof