mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: CJ <firefly0158@163.com>
To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com
Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [BUG] ocfs2: WARNING in ocfs2_journal_toggle_dirty on unmount
Date: Mon, 14 Sep 2026 15:44:04 +0800 (CST)	[thread overview]
Message-ID: <6587d633.6e53.1a09edf871b.Coremail.firefly0158@163.com> (raw)

Hi,


I am reporting a WARNING in the ocfs2 journal teardown path, triggered by a
syzkaller reproducer that mounts a crafted ocfs2 image.  The issue is
reproducible with HEAD commit cee9395acd8043be0644b25c34bfa86623f2b935
(v7.3-rc1, Linux 7.3.0-rc1).


The reproducer mounts a crafted ocfs2 image on a loop device and then unmounts
it.  The mount succeeds; the failure happens during unmount, when
ocfs2_dismount_volume shuts the journal down.


The console shows "WARNING: fs/ocfs2/journal.c:1029 at
ocfs2_journal_toggle_dirty+0x32c/0x3a0", reached from
ocfs2_journal_shutdown and then ocfs2_dismount_volume.  The warning fires while
the teardown is trying to toggle the journal dirty flag on a handle that the
log has already stopped.


On the kernel where this was first reported the same site was a BUG() at
fs/ocfs2/journal.c:973; on v7.3-rc1 it is reported as a WARNING at line 1029
instead, so the invariant still holds but the consequence has been downgraded.
Because the failure class differs between the two reports, I am describing this
as the same invariant rather than claiming a byte-for-byte identical splat.
One possible cause is that the crafted image leaves the on-disk journal
superblock state inconsistent with the in-memory journal, so the toggle is
attempted after the journal has been marked stopped.  I am reporting the
reproduction; if the downgraded warning is the intended outcome for a corrupt
image, please disregard this.


This appears to be a recurrence of the syzbot issue whose external id is
3aba35f80970c6e536b2.  It remains reproducible on v7.3-rc1.


Reproducer:


syz reproducer: https://pastebin.com/raw/Zev3Pr6Z
console output: https://pastebin.com/raw/jEDLm4Pj
kernel config: https://pastebin.com/raw/GvCKrhjZ


Kernel:


HEAD commit: cee9395acd8043be0644b25c34bfa86623f2b935
git tree: upstream (linux.git), tested through the v7.3-rc1 annotated tag object
           e5e04726cdd043e309677071ab1b65a4b18f422b
kernel version: 7.3.0-rc1 #1 PREEMPT(full)
tested tag: v7.3-rc1 (Linux 7.3-rc1, 2026-08-30)


Let me know if you need more details or testing.


Best regards,
Changjian




                 reply	other threads:[~2026-09-14  7:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6587d633.6e53.1a09edf871b.Coremail.firefly0158@163.com \
    --to=firefly0158@163.com \
    --cc=jlbec@evilplan.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®