From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F70DC433F5 for ; Mon, 25 Apr 2022 18:37:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244457AbiDYSkD (ORCPT ); Mon, 25 Apr 2022 14:40:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234489AbiDYSkB (ORCPT ); Mon, 25 Apr 2022 14:40:01 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42FF0201A8 for ; Mon, 25 Apr 2022 11:36:56 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id g23so12504910edy.13 for ; Mon, 25 Apr 2022 11:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ydNiU7IrIaCND48p0/RDJI06lFZyczTfdfRkiVUeW8I=; b=l73hcHZEi18QTdp+E3nZcuxNNVI85ZPRamsYOBKhKoF8H6lj21mm3351/qhk/047kT Kna9RplHzIIaYCN0Xx1Y76xufwbuYEk7xsymQptDb7eEQKufoznkuvRA3KSo/VaqVDcO 6B2F12H6OaZmg4fJm8hqxnya6Fnv+HFqQNFHX6PN1r4rxaXmb9risNZNimV2/D9pufGu D/CmI/xX5GsZSQRT/4uL76r2GmLYqXKoc1DQo8G45bQfDOtfgbMt74s7ms2P6eNQnghz nJGMWFz0zo98iQb3+5Sol5++Ldr2mGyJtz0WfZmBDroUJcV8GJeLAYg91kBrZ8LhKj0z c90A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ydNiU7IrIaCND48p0/RDJI06lFZyczTfdfRkiVUeW8I=; b=I1U5w/Bpu4BSdWmw7LQVJH5LT0FOQYzdEzGo21an2ncw91wvIPFnx0poK+nKiyykRC qyD9TA3OsRcuS4/5YTezOZqXsx+3jcQnLFkxp89ViMy0uPWDI7+HF1ZhLLZGpNCr/Z4b F9behgy7Z7e4qQjWcnFIHgk4W9pvy0yiOSed3gsyQxQkgKHKq5px3Cnj7SInKfrDTt99 cZBnr7F81+/uWw31jr5+1Tem8vu2xL5+LNy7RXwr+5ys6vCmQgNlTMb7ZQ47llJOjhH/ wi3BlQRPhdsFzRGVfVuucIJIr+AAe4XjMWTO6eHSRTkyK3RiHPSx1vZf+kdZSncShwZX xDOw== X-Gm-Message-State: AOAM532pkNxvuWizOQQbcQAL+x0+dMi5BlzNQaeWGFHBrtkAvb/BcBXV s4w6PygmxbLF4vCJwNXa7j5wpw== X-Google-Smtp-Source: ABdhPJwi05uX9rNkGQP4GNoyT0fYFCErBALKyIKKTJ3M5Oz/OvBf+2meZYdauaUjaJiQa46PgKKvEw== X-Received: by 2002:a05:6402:330b:b0:425:eded:7cfe with SMTP id e11-20020a056402330b00b00425eded7cfemr5100589eda.357.1650911814789; Mon, 25 Apr 2022 11:36:54 -0700 (PDT) Received: from [192.168.0.244] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id jo11-20020a170906f6cb00b006f3955761c4sm1416631ejb.158.2022.04.25.11.36.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 11:36:54 -0700 (PDT) Message-ID: <658851ed-33fd-8e2b-7db7-ef1ca9e31c33@linaro.org> Date: Mon, 25 Apr 2022 20:36:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: fsl,ls-extirq: convert to YAML Content-Language: en-US To: Michael Walle , Rob Herring , Krzysztof Kozlowski Cc: Li Yang , Shawn Guo , Thomas Gleixner , Marc Zyngier , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220425140214.32448-1-michael@walle.cc> From: Krzysztof Kozlowski In-Reply-To: <20220425140214.32448-1-michael@walle.cc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/04/2022 16:02, Michael Walle wrote: > Convert the fsl,ls-extirq binding to the new YAML format. > (...) > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml > new file mode 100644 > index 000000000000..39d120ad7549 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/fsl,ls-extirq.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale Layerscape External Interrupt Controller > + > +maintainers: > + - Shawn Guo > + - Li Yang > + > +description: | > + Some Layerscape SOCs (LS1021A, LS1043A, LS1046A LS1088A, LS208xA, > + LX216xA) support inverting the polarity of certain external interrupt > + lines. > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# I have doubts whether this is here applicable. See also Rob's comment: https://lore.kernel.org/all/YjjJpxLWJ%2FYOe0OX@robh.at.kernel.org/ This device does not have children, so the interrupt-controller schema should be probably skipped. > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,ls1021a-extirq > + - fsl,ls1043a-extirq > + - fsl,ls1088a-extirq > + - items: > + - enum: > + - fsl,ls1046a-extirq > + - const: fsl,ls1043a-extirq > + - items: > + - enum: > + - fsl,ls2080a-extirq > + - fsl,lx2160a-extirq > + - const: fsl,ls1088a-extirq > + > + '#interrupt-cells': > + const: 2 > + > + '#address-cells': > + const: 0 > + > + interrupt-controller: true > + > + reg: > + maxItems: 1 > + description: > + Specifies the Interrupt Polarity Control Register (INTPCR) in the > + SCFG or the External Interrupt Control Register (IRQCR) in the ISC. > + > + interrupt-map: > + description: Specifies the mapping from external interrupts to GIC interrupts. > + > + interrupt-map-mask: > + items: > + - const: 0xffffffff This looks highly permissive mask and should be instead defined per variant, for example (quickly looking at DTS): 0x7 for ls1021 0xf for ls1043a and ls1088a You might need to correct the DTS. Some confirmation from someone with datasheet would be good. Best regards, Krzysztof