From: Dan Carpenter <dan.carpenter@linaro.org>
To: Fei Shao <fshao@chromium.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clk: Fix memory leak in devm_clk_notifier_register()
Date: Mon, 19 Jun 2023 12:57:04 +0300 [thread overview]
Message-ID: <658d32f2-a71b-4dc2-bff9-649fadf41889@kadam.mountain> (raw)
In-Reply-To: <32fa8c0e-26f4-4ee4-889a-4037530c128d@kadam.mountain>
On Mon, Jun 19, 2023 at 12:24:41PM +0300, Dan Carpenter wrote:
> > It was actually detected by kmemleak on an unreleased Chromebook device.
> > I added the trace snippet in the message at first but removed that
> > before sending this. Maybe I shouldn't have.
> >
> > I can resend a v3 to add that back if that's preferable. What do you think?
The other reason to include stack traces is so that if someone else
runs into the same bug they can find your patch by googling their stack
trace.
Normal users aren't going to be running kmemleak. And people doing
testing work for companies are hopefully going to pull this fix in via
the stable tree so they'll get this patch automatically that way so
they won't see it either.
But if the stack trace is like a NULL dereference bug, then users
absolutely do notice that kind of thing. You should always include
those kind of stack traces.
regards,
dan carpenter
next prev parent reply other threads:[~2023-06-19 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 3:22 Fei Shao
2023-06-19 8:48 ` Dan Carpenter
2023-06-19 9:05 ` Fei Shao
2023-06-19 9:24 ` Dan Carpenter
2023-06-19 9:38 ` Fei Shao
2023-06-19 9:57 ` Dan Carpenter [this message]
2023-06-19 10:34 ` Fei Shao
2023-06-20 19:03 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658d32f2-a71b-4dc2-bff9-649fadf41889@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=fshao@chromium.org \
--cc=jbrunet@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®