From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28E6C34022 for ; Wed, 19 Feb 2020 03:34:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6F7424655 for ; Wed, 19 Feb 2020 03:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbgBSDed (ORCPT ); Tue, 18 Feb 2020 22:34:33 -0500 Received: from smtprelay0025.hostedemail.com ([216.40.44.25]:44318 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726446AbgBSDed (ORCPT ); Tue, 18 Feb 2020 22:34:33 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 8381F182CED2A; Wed, 19 Feb 2020 03:34:31 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: eggs49_276b585518d5b X-Filterd-Recvd-Size: 2918 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Wed, 19 Feb 2020 03:34:30 +0000 (UTC) Message-ID: <658fe8a43c01360813d11087ea974b12c02bb6b4.camel@perches.com> Subject: Re: [RFC PATCH 0/2] trace: Move trace data to new section _ftrace_data From: Joe Perches To: Steven Rostedt Cc: linux-kernel@vger.kernel.org Date: Tue, 18 Feb 2020 19:33:08 -0800 In-Reply-To: <20200218222615.713d542d@gandalf.local.home> References: <20200218215328.16744447@gandalf.local.home> <899e4e41c4cf5c62a4fbce0923e5796141ef46f0.camel@perches.com> <20200218222615.713d542d@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-02-18 at 22:26 -0500, Steven Rostedt wrote: > On Tue, 18 Feb 2020 19:09:10 -0800 > Joe Perches wrote: > > > I don't care about the section name at all. > > > > I used that name for consistency with _ftrace_event > > in the same file. > > Perhaps the _ftrace_event section > > name could be renamed to something > > intelligible too. > > Yes, that should probably get changed. That's a leftover when we just > called everything "ftrace", but it should have been changed when I > renamed the file from ftrace.h to trace_event.h. Pick a name. btw: it's not used in an x86-64 allmodconfig or defconfig as an actual separate section as far as I tell. $ git grep _ftrace_events include/asm-generic/vmlinux.lds.h: __start_ftrace_events = .; \ include/asm-generic/vmlinux.lds.h: KEEP(*(_ftrace_events)) \ include/asm-generic/vmlinux.lds.h: __stop_ftrace_events = .; \ include/linux/syscalls.h: __attribute__((section("_ftrace_events"))) \ include/linux/syscalls.h: __attribute__((section("_ftrace_events"))) \ include/trace/trace_events.h: * __section(_ftrace_events) *__event_ = &event_; include/trace/trace_events.h:static struct trace_event_call __used __section(_ftrace_events) \ include/trace/trace_events.h:static struct trace_event_call __used __section(_ftrace_events) \ kernel/module.c: mod->trace_events = section_objs(info, "_ftrace_events", kernel/trace/trace_events.c:extern struct trace_event_call *__start_ftrace_events[]; kernel/trace/trace_events.c:extern struct trace_event_call *__stop_ftrace_events[]; kernel/trace/trace_events.c: for_each_event(iter, __start_ftrace_events, __stop_ftrace_events) { kernel/trace/trace_export.c:static struct trace_event_call * __used __section(_ftrace_events) \