From: Paolo Bonzini <pbonzini@redhat.com>
To: Christoffer Dall <christoffer.dall@linaro.org>,
Maninder Singh <maninder1.s@samsung.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
marc.zyngier@arm.com, rkrcmar@redhat.com, cmetcalf@mellanox.com,
panand@redhat.com, mark.rutland@arm.com, james.morse@arm.com,
akpm@linux-foundation.org, sandeepa.s.prabhu@gmail.com,
labbott@redhat.com, shijie.huang@arm.com,
ard.biesheuvel@linaro.org, wangkefeng.wang@huawei.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org, pankaj.m@samsung.com, ajeet.y@samsung.com,
cpgs@samsung.com, Vaneet Narang <v.narang@samsung.com>
Subject: Re: [PATCH 1/1] arm64: Correcting format specifier for printing 64 bit addresses
Date: Wed, 14 Dec 2016 17:35:53 +0100 [thread overview]
Message-ID: <65935935-bdd9-c6a6-1a33-2bbaf6ffbbc5@redhat.com> (raw)
In-Reply-To: <20161206161116.GD4816@cbox>
On 06/12/2016 17:11, Christoffer Dall wrote:
> + kvm_err("Unsupported guest CP%d access at: %08lx\n",
> + cp, *vcpu_pc(vcpu));
> + else
> + kvm_err("Unsupported guest CP%d access at: %016lx\n",
> + cp, *vcpu_pc(vcpu));
>
> It feels a bit much to me to have an if-statement to differentiate the
> number of leading zeros, so if it's important to always have fixed
> widths then I would just use %016lx in both cases.
Really, this is just a debugging message. Just use "0x%lx" and let's
stop bikeshedding. :)
Paolo
next prev parent reply other threads:[~2016-12-14 16:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 8:09 Maninder Singh
2016-12-05 11:24 ` Will Deacon
2016-12-06 15:26 ` Catalin Marinas
2016-12-06 15:28 ` Will Deacon
2016-12-06 16:11 ` Christoffer Dall
2016-12-06 16:32 ` Robin Murphy
2016-12-14 16:35 ` Paolo Bonzini [this message]
2016-12-06 16:43 ` Robin Murphy
-- strict thread matches above, loose matches on Subject: below --
2016-12-05 8:06 Maninder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65935935-bdd9-c6a6-1a33-2bbaf6ffbbc5@redhat.com \
--to=pbonzini@redhat.com \
--cc=ajeet.y@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=cmetcalf@mellanox.com \
--cc=cpgs@samsung.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=panand@redhat.com \
--cc=pankaj.m@samsung.com \
--cc=rkrcmar@redhat.com \
--cc=sandeepa.s.prabhu@gmail.com \
--cc=shijie.huang@arm.com \
--cc=v.narang@samsung.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®