From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Dmitry Vyukov <dvyukov@google.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
Sasha Levin <sasha.levin@oracle.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2)
Date: Fri, 01 Jan 2016 21:12:40 +0100 [thread overview]
Message-ID: <65988221.D1d1cZYMWB@myon.chronox.de> (raw)
In-Reply-To: <20151230034753.GA8776@gondor.apana.org.au>
Am Mittwoch, 30. Dezember 2015, 11:47:53 schrieb Herbert Xu:
Hi Herbert,
> On Tue, Dec 29, 2015 at 07:36:14PM +0100, Dmitry Vyukov wrote:
> > Hello,
> >
> > On commit 8513342170278468bac126640a5d2d12ffbff106
> > + crypto: algif_skcipher - Use new skcipher interface
> > + crypto: algif_skcipher - Require setkey before accept(2)
> > + crypto: af_alg - Disallow bind/setkey/... after accept(2)
>
> OK there is a silly bug in the last patch. Here is an updated
> version.
With this patch, the AF_ALG interface stops working. I tested the HMAC
operation and I am unable to set the key with the following call:
ret = setsockopt(handle->tfmfd, SOL_ALG, ALG_SET_KEY, key, keylen);
This call returns EBUSY.
The test can be performed with [1] using the following call:
test/kcapi -x 3 -c "hmac(sha1)" -k 6e77ebd479da794707bc6cde3694f552ea892dab -p
31b62a797adbff6b8a358d2b5206e01fee079de8cdfc4695138bba163b4efbf30127343e7fd4fbc696c3d38d8f27f57c024b5056f726ceeb4c31d98e57751ec8cbe8904ee0f9b031ae6a0c55da5e062475b3d7832191d4057643ef5fa446801d59a04693e573a8159cd2416b7bd39c7f0fe63c599365e04d596c05736beaab58
Without the patch, all works.
[1] http://www.chronox.de/libkcapi.html
--
Ciao
Stephan
next prev parent reply other threads:[~2016-01-01 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 18:36 crypto: deadlock in alg_setsockopt Dmitry Vyukov
2015-12-30 3:47 ` [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2) Herbert Xu
2016-01-01 20:12 ` Stephan Mueller [this message]
2016-01-02 9:20 ` Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65988221.D1d1cZYMWB@myon.chronox.de \
--to=smueller@chronox.de \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kcc@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®