mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul Menage" <menage@google.com>
To: balbir@in.ibm.com
Cc: sekharan@us.ibm.com, ckrm-tech@lists.sourceforge.net,
	jlan@sgi.com, Simon.Derr@bull.net, linux-kernel@vger.kernel.org,
	pj@sgi.com, mbligh@google.com, winget@google.com,
	rohitseth@google.com
Subject: Re: [ckrm-tech] [PATCH 2/6] Cpusets hooked into containers
Date: Mon, 6 Nov 2006 12:55:53 -0800	[thread overview]
Message-ID: <6599ad830611061255u458a795bpca1c360cb93f253@mail.gmail.com> (raw)
In-Reply-To: <454ED769.8040302@in.ibm.com>

On 11/5/06, Balbir Singh <balbir@in.ibm.com> wrote:
>
> I needed the following patches to get the cpuset code to compile.
> Inlining two patches makes it hard to distinguish between the patches
> and harder to read them, so I am attaching them along with this email.

The first I missed due to not compiling with CONFIG_HOTPLUG_* - thanks
for the patch.

For the second, the following change to fs/proc/base.c should have
appeared in cpusets_using_containers.patch, but got left out due to
quilt misusage. It basically makes "cpuset" an alias for "container"
in the relevant /proc directories if CONFIG_CPUSETS_LEGACY_API is
defined.

--- container-2.6.19-rc2.orig/fs/proc/base.c
+++ container-2.6.19-rc2/fs/proc/base.c
@@ -69,7 +69,6 @@
 #include <linux/ptrace.h>
 #include <linux/seccomp.h>
 #include <linux/container.h>
-#include <linux/cpuset.h>
 #include <linux/audit.h>
 #include <linux/poll.h>
 #include <linux/nsproxy.h>
@@ -1784,8 +1783,8 @@ static struct pid_entry tgid_base_stuff[
 #ifdef CONFIG_CONTAINERS
 	REG("container",  S_IRUGO, container),
 #endif
-#ifdef CONFIG_CPUSETS
-	REG("cpuset",     S_IRUGO, cpuset),
+#ifdef CONFIG_CPUSETS_LEGACY_API
+	REG("cpuset",     S_IRUGO, container),
 #endif
 	INF("oom_score",  S_IRUGO, oom_score),
 	REG("oom_adj",    S_IRUGO|S_IWUSR, oom_adjust),
@@ -2061,8 +2060,8 @@ static struct pid_entry tid_base_stuff[]
 #ifdef CONFIG_CONTAINERS
 	REG("container",  S_IRUGO, container),
 #endif
-#ifdef CONFIG_CPUSETS
-	REG("cpuset",    S_IRUGO, cpuset),
+#ifdef CONFIG_CPUSETS_LEGACY_API
+	REG("cpuset",    S_IRUGO, container),
 #endif
 	INF("oom_score", S_IRUGO, oom_score),
 	REG("oom_adj",   S_IRUGO|S_IWUSR, oom_adjust),

Paul

  reply	other threads:[~2006-11-06 20:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-20 18:38 [PATCH 0/6] Generic Process Containers menage
2006-10-20 18:38 ` [PATCH 1/6] Generic container system abstracted from cpusets code menage
2006-10-20 18:38 ` [PATCH 2/6] Cpusets hooked into containers menage
2006-11-06  6:34   ` [ckrm-tech] " Balbir Singh
2006-11-06 20:55     ` Paul Menage [this message]
2006-11-06 21:09       ` Paul Jackson
2006-11-06 21:22         ` Paul Menage
2006-11-07 14:06       ` Balbir Singh
2006-10-20 18:38 ` [PATCH 3/6] Add generic multi-subsystem API to containers menage
2006-10-20 18:38 ` [PATCH 4/6] Simple CPU accounting container subsystem menage
2006-10-20 18:38 ` [PATCH 5/6] Extension to container system to allow fork/exit callbacks menage
2006-10-20 18:38 ` [PATCH 6/6] Resource Groups over generic containers menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6599ad830611061255u458a795bpca1c360cb93f253@mail.gmail.com \
    --to=menage@google.com \
    --cc=Simon.Derr@bull.net \
    --cc=balbir@in.ibm.com \
    --cc=ckrm-tech@lists.sourceforge.net \
    --cc=jlan@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@google.com \
    --cc=pj@sgi.com \
    --cc=rohitseth@google.com \
    --cc=sekharan@us.ibm.com \
    --cc=winget@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®