mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul Menage" <menage@google.com>
To: vatsa@in.ibm.com
Cc: "Paul Jackson" <pj@sgi.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	"Balbir Singh" <balbir@in.ibm.com>
Subject: Re: [PATCH] Fix race between attach_task and cpuset_exit
Date: Thu, 5 Apr 2007 01:10:21 -0700	[thread overview]
Message-ID: <6599ad830704050110w65c2312br3c8d070da5d6dfa5@mail.gmail.com> (raw)
In-Reply-To: <20070405081424.GA20356@in.ibm.com>

On 4/5/07, Srivatsa Vaddagiri <vatsa@in.ibm.com> wrote:
>
> Hmm yes ..I am surprised we arent doing a synhronize_rcu in
> cpuset_rmdir() before dropping the dentry. Did you want to send a patch
> for that?

Currently cpuset_exit() isn't in a rcu section so it wouldn't help.

But this ceases to be a problem if we don't leave the refcount
dropping in cpuset_exit() where it is currently - it doesn't drop the
refcount until it's holding manage_mutex, at which point it's safe to
hold a cpuset reference with a refcount of 0.

Paul

  reply	other threads:[~2007-04-05  8:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-25 16:47 Srivatsa Vaddagiri
2007-03-25 17:52 ` Balbir Singh
2007-03-25 19:54   ` Paul Jackson
2007-03-26 11:50   ` Srivatsa Vaddagiri
2007-03-26 17:58     ` Paul Jackson
2007-03-27  6:35       ` Srivatsa Vaddagiri
2007-03-27  8:45         ` Paul Jackson
2007-03-26 18:30     ` Paul Jackson
2007-03-25 19:50 ` Paul Jackson
2007-03-26 11:55   ` Srivatsa Vaddagiri
2007-04-05  5:55     ` Paul Menage
2007-04-05  7:00       ` Srivatsa Vaddagiri
2007-04-05  7:01         ` Paul Menage
2007-04-05  8:14           ` Srivatsa Vaddagiri
2007-04-05  8:10             ` Paul Menage [this message]
2007-04-10 17:12       ` Srivatsa Vaddagiri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6599ad830704050110w65c2312br3c8d070da5d6dfa5@mail.gmail.com \
    --to=menage@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pj@sgi.com \
    --cc=vatsa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®