mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul Menage" <menage@google.com>
To: "Vaidyanathan Srinivasan" <svaidy@linux.vnet.ibm.com>
Cc: vatsa@in.ibm.com, sekharan@us.ibm.com,
	ckrm-tech@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	xemul@sw.ru, dev@sw.ru, rohitseth@google.com,
	ebiederm@xmission.com, mbligh@google.com,
	containers@lists.osdl.org, serue@us.ibm.com,
	akpm@linux-foundation.org, devel@openvz.org
Subject: Re: [ckrm-tech] [PATCH 0/7] Containers (V8): Generic Process Containers
Date: Tue, 24 Apr 2007 22:04:53 -0700	[thread overview]
Message-ID: <6599ad830704242204n75e6340cn280999122c54530f@mail.gmail.com> (raw)
In-Reply-To: <462C9375.5030901@linux.vnet.ibm.com>

On 4/23/07, Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> wrote:
> Hi Paul,
>
> In [patch 3/7] Containers (V8): Add generic multi-subsystem API to
> containers, you have forcefully enabled interrupt in
> container_init_subsys() with spin_unlock_irq() which breaks on PPC64.
>
>
> > +static void container_init_subsys(struct container_subsys *ss) {
> > +     int retval;
> > +     struct list_head *l;
> > +     printk(KERN_ERR "Initializing container subsys %s\n",
> > ss->name);
> > +
> > +     /* Create the top container state for this subsystem */
> > +     ss->root = &rootnode;
> > +     retval = ss->create(ss, dummytop);
> > +     BUG_ON(retval);
> > +     init_container_css(ss, dummytop);
> > +
> > +     /* Update all container groups to contain a subsys
> > +      * pointer to this state - since the subsystem is
> > +      * newly registered, all tasks and hence all container
> > +      * groups are in the subsystem's top container. */
> > +     spin_lock_irq(&container_group_lock);
> > +     l = &init_container_group.list;
> > +     do {
> > +             struct container_group *cg =
> > +                     list_entry(l, struct container_group, list);
> > +             cg->subsys[ss->subsys_id] =
> > dummytop->subsys[ss->subsys_id];
> > +             l = l->next;
> > +     } while (l != &init_container_group.list);
> > +     spin_unlock_irq(&container_group_lock);
>
> Interrupt gets enabled here and on PPC64, the kernel takes a pending
> decrementer and crashes because it is too early to handle them.
>
> Use of irqsave and restore routines would fix the problem.

OK, thanks. I'll add that change.

Paul

      reply	other threads:[~2007-04-25  5:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-06 23:32 menage
2007-04-06 23:32 ` [PATCH 1/7] Containers (V8): Generic container system abstracted from cpusets code menage
2007-04-06 23:32 ` [PATCH 2/7] Containers (V8): Cpusets hooked into containers menage
2007-04-23 10:52   ` Vaidyanathan Srinivasan
2007-04-25  4:59     ` Paul Menage
2007-04-06 23:32 ` [PATCH 4/7] Containers (V8): Simple CPU accounting container subsystem menage
2007-04-10 13:16   ` Srivatsa Vaddagiri
2007-04-06 23:32 ` [PATCH 5/7] Containers (V8): Resource Groups over generic containers menage
2007-04-06 23:32 ` [PATCH 6/7] Containers (V8): BeanCounters over generic process containers menage
2007-04-09  7:46   ` Pavel Emelianov
2007-04-09 16:44   ` William Lee Irwin III
2007-04-06 23:32 ` [PATCH 7/7] Containers (V8): Container interface to nsproxy subsystem menage
     [not found] ` <20070407001324.271959000@menage.corp.google.com>
2007-04-07  1:58   ` [ckrm-tech] [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers Paul Menage
2007-04-07  4:18   ` Srivatsa Vaddagiri
2007-04-07 17:30     ` Paul Menage
2007-04-10 14:42   ` Srivatsa Vaddagiri
2007-04-10 14:52   ` Srivatsa Vaddagiri
2007-04-10 15:45     ` [ckrm-tech] " Paul Menage
2007-04-11  4:47   ` Srivatsa Vaddagiri
2007-04-11  5:01   ` Srivatsa Vaddagiri
2007-04-11  8:42     ` Paul Menage
2007-04-11 16:42   ` Srivatsa Vaddagiri
2007-04-23 11:07 ` [PATCH 0/7] Containers (V8): Generic Process Containers Vaidyanathan Srinivasan
2007-04-25  5:04   ` Paul Menage [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6599ad830704242204n75e6340cn280999122c54530f@mail.gmail.com \
    --to=menage@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=ckrm-tech@lists.sourceforge.net \
    --cc=containers@lists.osdl.org \
    --cc=dev@sw.ru \
    --cc=devel@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@google.com \
    --cc=rohitseth@google.com \
    --cc=sekharan@us.ibm.com \
    --cc=serue@us.ibm.com \
    --cc=svaidy@linux.vnet.ibm.com \
    --cc=vatsa@in.ibm.com \
    --cc=xemul@sw.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®