From: "Paul Menage" <menage@google.com>
To: "Paul Jackson" <pj@sgi.com>
Cc: akpm@linux-foundation.org, nickpiggin@yahoo.com.au,
a.p.zijlstra@chello.nl, serue@us.ibm.com, clg@fr.ibm.com,
linux-kernel@vger.kernel.org, ebiederm@xmission.com,
rientjes@google.com, svaidy@linux.vnet.ibm.com, xemul@openvz.org,
containers@lists.osdl.org, balbir@linux.vnet.ibm.com
Subject: Re: [PATCH] task containersv11 add tasks file interface fix for cpusets
Date: Wed, 3 Oct 2007 11:10:58 -0700 [thread overview]
Message-ID: <6599ad830710031110r1a74eafej56f20cc33e72ac81@mail.gmail.com> (raw)
In-Reply-To: <20071003105817.7adf6516.pj@sgi.com>
On 10/3/07, Paul Jackson <pj@sgi.com> wrote:
>
> Yes, something in user space has to do it. It's part of the
> kernel-user cpuset API. If you change a cpuset's 'cpus', then
> you have to rewrite each pid in its 'tasks' file back to that
> 'tasks' file in order to get that 'cpus' change to be applied
> to the task struct cpus_allowed of each task, and thereby visible
> to the scheduler.
What's the rationale for this?
Given that later in cpusets.txt you say:
>If hotplug functionality is used
>to remove all the CPUs that are currently assigned to a cpuset,
>then the kernel will automatically update the cpus_allowed of all
>tasks attached to CPUs in that cpuset to allow all CPUs
why can't the same thing be done when changing the 'cpus' file manually.
What's wrong with, in update_cpumask(), doing a loop across all
members of the cgroup and updating their cpus_allowed fields?
The existing cpusets API is broken, since a new child can always be
forked between reading the tasks file and doing the writes.
Paul
next prev parent reply other threads:[~2007-10-03 18:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 8:42 Paul Jackson
2007-10-03 15:51 ` Paul Menage
2007-10-03 17:58 ` Paul Jackson
2007-10-03 18:10 ` Paul Menage [this message]
2007-10-03 18:25 ` Paul Menage
2007-10-03 20:16 ` Paul Jackson
2007-10-03 20:31 ` Paul Menage
2007-10-03 20:52 ` Paul Jackson
2007-10-03 20:58 ` Paul Menage
2007-10-06 8:24 ` Paul Jackson
2007-10-06 17:54 ` David Rientjes
2007-10-06 19:59 ` Paul Jackson
2007-10-06 21:09 ` Paul Menage
2007-10-06 21:41 ` Paul Jackson
2007-10-11 22:03 ` Paul Jackson
2007-10-11 23:20 ` Eric W. Biederman
2007-10-12 1:23 ` Paul Jackson
2007-10-07 6:13 ` David Rientjes
2007-10-06 21:11 ` Paul Menage
2007-10-07 6:15 ` David Rientjes
2007-10-10 20:46 ` Paul Menage
2007-10-10 20:59 ` David Rientjes
2007-10-11 23:15 ` Paul Jackson
2007-10-12 15:13 ` David Rientjes
2007-10-06 20:53 ` Paul Menage
2007-10-03 20:56 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830710031110r1a74eafej56f20cc33e72ac81@mail.gmail.com \
--to=menage@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@sgi.com \
--cc=rientjes@google.com \
--cc=serue@us.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®