mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul Menage" <menage@google.com>
To: "Adrian Bunk" <bunk@kernel.org>
Cc: "Paul Jackson" <pj@sgi.com>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kernel/cgroup.c: make 2 functions static
Date: Wed, 24 Oct 2007 09:46:15 -0700	[thread overview]
Message-ID: <6599ad830710240946u2eb97013u4ad967ec7d801188@mail.gmail.com> (raw)
In-Reply-To: <20071024162339.GT30533@stusta.de>

On 10/24/07, Adrian Bunk <bunk@kernel.org> wrote:
> cgroup_is_releasable() and notify_on_release() should be static,
> not global inline.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

Acked-by: Paul Menage <menage@google.com>

>
> ---
>
>  kernel/cgroup.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> 626d10ec224de07fc7906b0aa82e035e153709ce
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 5987dcc..fec1726 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -143,7 +143,7 @@ enum {
>         ROOT_NOPREFIX, /* mounted subsystems have no named prefix */
>  };
>
> -inline int cgroup_is_releasable(const struct cgroup *cgrp)
> +static int cgroup_is_releasable(const struct cgroup *cgrp)
>  {
>         const int bits =
>                 (1 << CGRP_RELEASABLE) |
> @@ -151,7 +151,7 @@ inline int cgroup_is_releasable(const struct cgroup *cgrp)
>         return (cgrp->flags & bits) == bits;
>  }
>
> -inline int notify_on_release(const struct cgroup *cgrp)
> +static int notify_on_release(const struct cgroup *cgrp)
>  {
>         return test_bit(CGRP_NOTIFY_ON_RELEASE, &cgrp->flags);
>  }
>
>

      parent reply	other threads:[~2007-10-24 16:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24 16:23 Adrian Bunk
2007-10-24 16:32 ` Paul Menage
2007-10-24 16:41   ` Adrian Bunk
2007-10-24 16:46 ` Paul Menage [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6599ad830710240946u2eb97013u4ad967ec7d801188@mail.gmail.com \
    --to=menage@google.com \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®