From: "Paul Menage" <menage@google.com>
To: "Dhaval Giani" <dhaval@linux.vnet.ibm.com>
Cc: vatsa@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com,
mingo@elte.hu, linux-kernel@vger.kernel.org,
a.p.zijlstra@chello.nl, akpm@linux-foundation.org,
skumar@linux.vnet.ibm.com
Subject: Re: [patch 2/2] sched: allow cpuacct stats to be reset
Date: Fri, 29 Feb 2008 02:08:45 -0800 [thread overview]
Message-ID: <6599ad830802290208l6b9d97d1l67e351fc2f9112f7@mail.gmail.com> (raw)
In-Reply-To: <20080229060435.GB5478@linux.vnet.ibm.com>
On Thu, Feb 28, 2008 at 10:04 PM, Dhaval Giani
<dhaval@linux.vnet.ibm.com> wrote:
> On Thu, Feb 28, 2008 at 09:48:51PM -0800, Paul Menage wrote:
>
> > On Thu, Feb 28, 2008 at 8:32 PM, Dhaval Giani <dhaval@linux.vnet.ibm.com> wrote:
> >
>
> > Can I suggest, in order to be more generic, that this patch instead
> > set each CPU's counter to the written value divided by the number of
> > CPUs? (Either forgetting the remainder, or spreading it among the
> > first few CPUs).
> >
>
> This patch is only allowing a reset of the stats. In what sort of a
> situation would one be looking for changing the usage value?
How about Checkpoint/Restart?
It seems that if you're going to the effort to notice a non-zero value
and return an error, it wouldn't be much more effort to do something
useful with that non-zero value instead.
Paul
next prev parent reply other threads:[~2008-02-29 10:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 4:32 [patch 0/2] sched: cpuacct: minor cleanups and reset for cpuusage Dhaval Giani
2008-02-29 4:32 ` [patch 1/2] sched: cleanup cpuacct variable names Dhaval Giani
2008-03-07 4:58 ` Balbir Singh
2008-03-07 8:58 ` Ingo Molnar
2008-02-29 4:32 ` [patch 2/2] sched: allow cpuacct stats to be reset Dhaval Giani
2008-02-29 5:48 ` Paul Menage
2008-02-29 6:02 ` Srivatsa Vaddagiri
2008-02-29 6:04 ` Dhaval Giani
2008-02-29 10:08 ` Paul Menage [this message]
2008-02-29 10:38 ` Peter Zijlstra
2008-03-07 5:00 ` Balbir Singh
2008-03-07 8:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830802290208l6b9d97d1l67e351fc2f9112f7@mail.gmail.com \
--to=menage@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=skumar@linux.vnet.ibm.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®