From: "Paul Menage" <menage@google.com>
To: balbir@linux.vnet.ibm.com
Cc: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
"Pavel Emelianov" <xemul@openvz.org>,
"Hugh Dickins" <hugh@veritas.com>,
"Sudhir Kumar" <skumar@linux.vnet.ibm.com>,
"YAMAMOTO Takashi" <yamamoto@valinux.co.jp>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
taka@valinux.co.jp, linux-mm@kvack.org,
"David Rientjes" <rientjes@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [-mm] Add an owner to the mm_struct (v2)
Date: Fri, 28 Mar 2008 04:04:17 -0700 [thread overview]
Message-ID: <6599ad830803280404i475c9824i31741af5a8ebf376@mail.gmail.com> (raw)
In-Reply-To: <47ECCE00.70803@linux.vnet.ibm.com>
On Fri, Mar 28, 2008 at 3:52 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > How about changing this css_get()/css_put() from accounting against mm_struct
> > to accouting against task_struct ?
> > It seems simpler way after this mm->owner change.
>
> But the reason why we account the mem_cgroup is that we don't want the
> mem_cgroup to be deleted. I hope you meant mem_cgroup instead of mm_struct.
>
If there are any tasks in the cgroup then the cgroup can't be deleted,
and hence the mem_cgroup is safe.
css_get()/css_put() is only needed when you have a reference from a
non-task object that needs to keep the mem_cgroup alive, which is no
longer the case for mm_struct once we have mm->owner.
Paul
next prev parent reply other threads:[~2008-03-28 11:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 8:23 Balbir Singh
2008-03-28 9:41 ` Jiri Slaby
2008-03-28 9:43 ` Jiri Slaby
2008-03-28 10:11 ` Balbir Singh
2008-03-28 10:48 ` KAMEZAWA Hiroyuki
2008-03-28 10:51 ` Balbir Singh
2008-03-28 11:06 ` KAMEZAWA Hiroyuki
2008-03-28 10:55 ` KAMEZAWA Hiroyuki
2008-03-28 10:52 ` Balbir Singh
2008-03-28 11:04 ` Paul Menage [this message]
2008-03-28 11:15 ` KAMEZAWA Hiroyuki
2008-03-28 11:21 ` KAMEZAWA Hiroyuki
2008-03-28 11:01 ` Paul Menage
2008-03-28 12:36 ` Balbir Singh
2008-03-28 12:54 ` Balbir Singh
2008-03-28 14:06 ` Paul Menage
2008-03-28 14:05 ` Paul Menage
2008-03-28 14:52 ` Balbir Singh
2008-03-28 15:38 ` Paul Menage
2008-03-28 18:10 ` Balbir Singh
2008-03-28 18:52 ` Paul Menage
2008-03-29 1:02 ` Balbir Singh
2008-03-29 5:46 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830803280404i475c9824i31741af5a8ebf376@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=rientjes@google.com \
--cc=skumar@linux.vnet.ibm.com \
--cc=taka@valinux.co.jp \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®