From: "Paul Menage" <menage@google.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: pj@sgi.com, xemul@openvz.org, balbir@in.ibm.com,
serue@us.ibm.com, linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [RFC/PATCH 1/8]: CGroup Files: Add locking mode to cgroups control files
Date: Tue, 13 May 2008 14:46:05 -0700 [thread overview]
Message-ID: <6599ad830805131446w11dadd4ag69db715e81513b3d@mail.gmail.com> (raw)
In-Reply-To: <20080513143206.ef259829.akpm@linux-foundation.org>
On Tue, May 13, 2008 at 2:32 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> But do we ever expect that cgroup_mutex will be taken with much
> frequency, or held for much time? If it's only taken during, say,
> configuration of a group or during a query of that configuration then
> perhaps we'll be OK.
I'm not so worried about contention on the userspace configuration
side - more the case of configuration operations stalling
subsystem-initiated operations. An example of that would be the case
of hierarchical reclaim in the memory controller, where it needs to be
able to traverse up and down the hierarchy without the hierarchy
changing under its feet.
I'll dump the implicit lock_mode support and make it more explicit in
the subsystem handlers.
Paul
next prev parent reply other threads:[~2008-05-13 21:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 6:37 [RFC/PATCH 0/8]: CGroup Files: Clean up locking and boilerplate menage
2008-05-13 6:37 ` [RFC/PATCH 1/8]: CGroup Files: Add locking mode to cgroups control files menage
2008-05-13 9:23 ` Li Zefan
2008-05-13 21:07 ` Paul Menage
2008-05-14 1:30 ` Li Zefan
2008-05-14 1:40 ` Paul Menage
2008-05-13 20:01 ` Andrew Morton
2008-05-13 20:38 ` Matthew Helsley
2008-05-13 20:43 ` Andrew Morton
2008-05-13 21:17 ` Paul Menage
2008-05-13 21:32 ` Andrew Morton
2008-05-13 21:46 ` Paul Menage [this message]
2008-05-14 1:59 ` Paul Jackson
2008-05-13 6:37 ` [RFC/PATCH 2/8]: CGroup Files: Add a cgroup write_string control file method menage
2008-05-13 20:07 ` Andrew Morton
2008-05-13 21:01 ` Paul Menage
2008-05-13 20:44 ` Matt Helsley
2008-05-13 6:37 ` [RFC/PATCH 3/8]: CGroup Files: Move the release_agent file to use typed handlers menage
2008-05-13 20:08 ` Andrew Morton
2008-05-13 21:32 ` Paul Menage
2008-05-13 6:37 ` [RFC/PATCH 4/8]: CGroup Files: Move notify_on_release file to separate write handler menage
2008-05-13 6:37 ` [RFC/PATCH 5/8]: CGroup Files: Turn attach_task_by_pid directly into a cgroup " menage
2008-05-13 6:37 ` [RFC/PATCH 6/8]: CGroup Files: Remove cpuset_common_file_write() menage
2008-05-13 20:11 ` Andrew Morton
2008-05-13 21:27 ` Paul Menage
2008-05-13 6:37 ` [RFC/PATCH 7/8]: CGroup Files: Convert devcgroup_access_write() into a cgroup write_string() handler menage
2008-05-13 6:37 ` [RFC/PATCH 8/8]: CGroup Files: Convert res_counter_write() to be a cgroups " menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830805131446w11dadd4ag69db715e81513b3d@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=serue@us.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®