From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935020AbYEVIYN (ORCPT ); Thu, 22 May 2008 04:24:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761883AbYEVIXx (ORCPT ); Thu, 22 May 2008 04:23:53 -0400 Received: from smtp-out.google.com ([216.239.33.17]:53537 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759676AbYEVIXv (ORCPT ); Thu, 22 May 2008 04:23:51 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=received:message-id:date:from:to:subject:cc:in-reply-to: mime-version:content-type:content-transfer-encoding: content-disposition:references; b=RMWR8k6peAMeTQT8+R4DB3ilZ73sWIq1Ak+t5sxzOW+UY5V+b/dfi41IrbqqwgDdg hZWRjVGDaAUsJD/UsCDqw== Message-ID: <6599ad830805220123t7a3848eeg244393723d5fd08d@mail.gmail.com> Date: Thu, 22 May 2008 01:23:35 -0700 From: "Paul Menage" To: "Andrew Morton" Subject: Re: [PATCH -mm] remove node_ prefix_from ns subsystem Cc: "Cedric Le Goater" , "Serge E. Hallyn" , "Linux Kernel Mailing List" , "Linux Containers" In-Reply-To: <20080522011053.680f7f65.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48344409.9090903@fr.ibm.com> <20080521220657.12e8e8c9.akpm@linux-foundation.org> <6599ad830805220011u77313ed7s2c0c9d4a658133cc@mail.gmail.com> <20080522003213.d677ba30.akpm@linux-foundation.org> <48352277.4010703@fr.ibm.com> <20080522011053.680f7f65.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Thu, May 22, 2008 at 1:10 AM, Andrew Morton wrote: > > What the change is, why it is being made, what the user-visible > presentation is, what the impact upon users is, why we think it won't > be a problem, etc? The stuff which should have been right there from > day one, before the code change was even made? The change is that previously when cgroup_clone() was called (currently only from the unshare path in ns_proxy cgroup, you'd get a new group named "node_$pid" whereas now you'll get a group named after just your pid.) The only users who would notice it are those who are using the ns_proxy cgroup subsystem to auto-create cgroups when namespaces are unshared - something of an experimental feature, which I think really needs more complete container/namespace support in order to be useful. I suspect the only users are Cedric and Serge, or maybe a few others on containers@lists.linux-foundation.org. And in fact it would only be noticed by the users who make the assumption about how the name is generated, rather than getting it from the /proc//cgroups file for the process in question. Whether the change is actually needed or not I'm fairly agnostic on, but I guess it is more elegant to just use the pid as the new group name rather than adding a fairly arbitrary "node_" prefix on the front. Paul