From: "Paul Menage" <menage@google.com>
To: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>,
"Balbir Singh" <balbir@linux.vnet.ibm.com>,
"Pavel Emelianov" <xemul@openvz.org>
Cc: containers@lists.osdl.org, LKML <linux-kernel@vger.kernel.org>,
"Li Zefan" <lizf@cn.fujitsu.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] introduce task cgroup v2
Date: Sat, 21 Jun 2008 00:56:07 -0700 [thread overview]
Message-ID: <6599ad830806210056n44c7ff37g7cd643f95aef4aa0@mail.gmail.com> (raw)
In-Reply-To: <20080616103035.788A.KOSAKI.MOTOHIRO@jp.fujitsu.com>
On Sun, Jun 15, 2008 at 6:32 PM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
>
> honestly, I used res_counter on early version.
> but I got bad performance.
Bad performance on the charge/uncharge?
The only difference I can see is that res_counter uses
spin_lock_irqsave()/spin_unlock_irqrestore(), and you're using plain
spin_lock()/spin_unlock().
Is the overhead of a pushf/cli/popf really going to matter compared
with the overhead of forking/exiting a task?
Or approaching this from the other side, does res_counter really need
irq-safe locking, or is it just being cautious?
Paul
next prev parent reply other threads:[~2008-06-21 7:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-07 11:00 KOSAKI Motohiro
2008-06-10 5:22 ` Li Zefan
2008-06-16 2:16 ` KOSAKI Motohiro
2008-06-16 7:01 ` Li Zefan
2008-06-16 7:06 ` KOSAKI Motohiro
2008-06-11 7:45 ` Paul Menage
2008-06-16 1:32 ` KOSAKI Motohiro
2008-06-21 7:56 ` Paul Menage [this message]
2008-06-21 8:56 ` Balbir Singh
2008-06-21 9:10 ` KOSAKI Motohiro
2008-06-21 15:48 ` Paul Menage
2008-06-21 17:01 ` KOSAKI Motohiro
2008-06-21 17:04 ` Balbir Singh
2008-06-21 17:22 ` KOSAKI Motohiro
2008-06-14 4:46 ` Randy Dunlap
2008-06-16 2:07 ` KOSAKI Motohiro
2008-06-16 6:39 ` Peter Zijlstra
2008-06-16 6:59 ` KOSAKI Motohiro
2008-06-16 7:04 ` Peter Zijlstra
2008-06-16 7:07 ` Li Zefan
2008-06-16 7:09 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830806210056n44c7ff37g7cd643f95aef4aa0@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®