From: "Paul Menage" <menage@google.com>
To: "Li Zefan" <lizf@cn.fujitsu.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Serge E. Hallyn" <serue@us.ibm.com>,
"Pavel Emelianov" <xemul@openvz.org>
Subject: Re: [PATCH 1/2] devcgroup: always show unsigned major/minor num
Date: Mon, 7 Jul 2008 18:32:58 -0700 [thread overview]
Message-ID: <6599ad830807071832j42a20faak62c5cdc98aca2d2@mail.gmail.com> (raw)
In-Reply-To: <4872C299.8060207@cn.fujitsu.com>
On Mon, Jul 7, 2008 at 6:27 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>>> @@ -254,7 +254,7 @@ static void set_majmin(char *str, unsigned m)
>>> if (m == ~0)
>>> sprintf(str, "*");
>>
>> Can't this just be strcat(str, "*")?
>>
>
> No, but it can be strcpy(str, "*").
Oops, yes, that's what I should have put ...
Paul
prev parent reply other threads:[~2008-07-08 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-05 5:39 Li Zefan
2008-07-07 15:46 ` Serge E. Hallyn
2008-07-07 19:13 ` Paul Menage
2008-07-08 1:27 ` Li Zefan
2008-07-08 1:32 ` Paul Menage [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830807071832j42a20faak62c5cdc98aca2d2@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=serue@us.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome