From: "Paul Menage" <menage@google.com>
To: "Lai Jiangshan" <laijs@cn.fujitsu.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Containers" <containers@lists.linux-foundation.org>
Subject: Re: [PATCH] cgroup(fix critical bug): new handling for tasks file
Date: Tue, 26 Aug 2008 15:40:48 -0700 [thread overview]
Message-ID: <6599ad830808261540j2b5c46cdsc42e26fa43f3f8d1@mail.gmail.com> (raw)
In-Reply-To: <48B39319.7070403@cn.fujitsu.com>
On Mon, Aug 25, 2008 at 10:22 PM, Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
>> But improving the current code has been on my todo list for a while.
>> My thought on the best way to fix it is to use a proper seq_file -
>> that would remove the issues that you have currently with the
>> "unconsumed" portion of the output.
>
> But for my poor knowledge we always have to handle "unconsumed portion"
> for nonseekable file in all different way. In my binary search based
> solving, I have to handle unconsumed part for a pid and bring in
> some complicated. This is really a disadvantage as you pointed out.
I meant that the seq_file code could handle the "unconsumed" portion
for you, rather than you having to manage it explicitly.
Paul
next prev parent reply other threads:[~2008-08-26 22:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 1:47 Lai Jiangshan
2008-08-26 2:29 ` Paul Menage
2008-08-26 5:22 ` Lai Jiangshan
2008-08-26 22:40 ` Paul Menage [this message]
2008-08-26 22:44 ` Paul Menage
2008-08-27 4:29 ` Lai Jiangshan
2008-08-27 12:36 ` Paul Menage
2008-08-28 12:09 ` Lai Jiangshan
2008-09-05 5:34 ` Paul Menage
2008-09-08 8:19 ` Lai Jiangshan
2008-09-08 15:42 ` Paul Menage
2008-09-08 21:16 ` Andrew Morton
2008-09-08 22:05 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830808261540j2b5c46cdsc42e26fa43f3f8d1@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®