From: "Paul Menage" <menage@google.com>
To: "Li Zefan" <lizf@cn.fujitsu.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Linux Containers" <containers@lists.linux-foundation.org>
Subject: Re: [PATCH] cgroup: tiny cleanups
Date: Mon, 20 Oct 2008 13:31:37 -0700 [thread overview]
Message-ID: <6599ad830810201331t639dbd55h5f17c382ca3a7fbd@mail.gmail.com> (raw)
In-Reply-To: <48FC1784.70108@cn.fujitsu.com>
On Sun, Oct 19, 2008 at 10:30 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> - remove 'private' field from struct subsys
> - remove cgroup_init_smp()
> - remove unused 'i' in cgroup_tasks_start()
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Paul Menage <menage@google.com>
Thanks. The cgroup_subsys.private field was originally for some
experiments for automatically emulating CKRM/BeanCounters over early
versions of cgroups, but I don't think anything is using it currently.
Paul
> ---
> include/linux/cgroup.h | 4 ----
> kernel/cgroup.c | 1 -
> 2 files changed, 5 deletions(-)
>
> --- linux-mm/include/linux/cgroup.h.orig 2008-10-20 13:25:39.000000000 +0800
> +++ linux-mm/include/linux/cgroup.h 2008-10-20 13:26:08.000000000 +0800
> @@ -25,7 +25,6 @@ struct cgroup;
>
> extern int cgroup_init_early(void);
> extern int cgroup_init(void);
> -extern void cgroup_init_smp(void);
> extern void cgroup_lock(void);
> extern bool cgroup_lock_live_group(struct cgroup *cgrp);
> extern void cgroup_unlock(void);
> @@ -348,8 +347,6 @@ struct cgroup_subsys {
> struct cgroupfs_root *root;
>
> struct list_head sibling;
> -
> - void *private;
> };
>
> #define SUBSYS(_x) extern struct cgroup_subsys _x ## _subsys;
> @@ -410,7 +407,6 @@ void cgroup_mm_owner_callbacks(struct ta
>
> static inline int cgroup_init_early(void) { return 0; }
> static inline int cgroup_init(void) { return 0; }
> -static inline void cgroup_init_smp(void) {}
> static inline void cgroup_fork(struct task_struct *p) {}
> static inline void cgroup_fork_callbacks(struct task_struct *p) {}
> static inline void cgroup_post_fork(struct task_struct *p) {}
> --- linux-mm/kernel/cgroup.c.orig 2008-10-20 13:25:56.000000000 +0800
> +++ linux-mm/kernel/cgroup.c 2008-10-20 13:26:08.000000000 +0800
> @@ -2104,7 +2104,6 @@ static void *cgroup_tasks_start(struct s
> down_read(&cgrp->pids_mutex);
> if (pid) {
> int end = cgrp->pids_length;
> - int i;
> while (index < end) {
> int mid = (index + end) / 2;
> if (cgrp->tasks_pids[mid] == pid) {
>
prev parent reply other threads:[~2008-10-20 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 5:30 Li Zefan
2008-10-20 20:31 ` Paul Menage [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830810201331t639dbd55h5f17c382ca3a7fbd@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®