mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menage <menage@google.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH 2/2] cpuset: use cgroup_path() in proc_cpuset_show()
Date: Fri, 21 Nov 2008 10:56:58 -0800	[thread overview]
Message-ID: <6599ad830811211056x205f0fc7k6b0472dc34c03c69@mail.gmail.com> (raw)
In-Reply-To: <4926762E.9010207@cn.fujitsu.com>

On Fri, Nov 21, 2008 at 12:49 AM, Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
>
> use cgroup_path() instead of
> task_subsys_state(tsk, cpuset_subsys_id)->cgroup

You mean:

use task_cgroup() instead of task_subsys_state()->cgroup

>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/kernel/cpuset.c b/kernel/cpuset.c
> index 3e00526..e0e087e 100644
> --- a/kernel/cpuset.c
> +++ b/kernel/cpuset.c
> @@ -2387,7 +2386,7 @@ static int proc_cpuset_show(struct seq_file *m, void *unused_v)
>        struct pid *pid;
>        struct task_struct *tsk;
>        char *buf;
> -       struct cgroup_subsys_state *css;
> +       struct cgroup *cgp;
>        int retval;
>
>        retval = -ENOMEM;
> @@ -2403,8 +2402,8 @@ static int proc_cpuset_show(struct seq_file *m, void *unused_v)
>
>        retval = -EINVAL;
>        cgroup_lock();
> -       css = task_subsys_state(tsk, cpuset_subsys_id);
> -       retval = cgroup_path(css->cgroup, buf, PAGE_SIZE);
> +       cgp = task_cgroup(tsk, cpuset_subsys_id);
> +       retval = cgroup_path(cgp, buf, PAGE_SIZE);
>        if (retval < 0)
>                goto out_unlock;
>        seq_puts(m, buf);
>
>
>

      reply	other threads:[~2008-11-21 18:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21  8:49 Lai Jiangshan
2008-11-21 18:56 ` Paul Menage [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6599ad830811211056x205f0fc7k6b0472dc34c03c69@mail.gmail.com \
    --to=menage@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®