From: Paul Menage <menage@google.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH 3/3] cgroups: introduce link_css_set() to remove duplicate code
Date: Tue, 2 Dec 2008 14:16:29 -0800 [thread overview]
Message-ID: <6599ad830812021416s76e393c8x5e3f5afa1bc370e2@mail.gmail.com> (raw)
In-Reply-To: <4934A8FB.80904@cn.fujitsu.com>
On Mon, Dec 1, 2008 at 7:18 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>
> How about:
>
> /**
> * link_css_set - a helper function to link a css_set to a cgroup
> * @ tmp_cg_links: cg_cgroup_link objects allocated by allocate_cg_links()
> * @ cg: the css_set to be linked
> * @ cgrp: the destination cgroup
> */
Sounds good.
>
> Because we are linking all the css_sets to the root cgroup, so I think root_cgrp
> helps readability.
>
But we're creating the hierarchy at this point, so there can clearly
only be one cgroup any (which is the root cgroup).
I don't think it's any more or less readable, it just seems an
unnecessary change.
Paul
prev parent reply other threads:[~2008-12-02 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 10:02 Li Zefan
2008-12-02 0:20 ` Paul Menage
2008-12-02 3:18 ` Li Zefan
2008-12-02 22:16 ` Paul Menage [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830812021416s76e393c8x5e3f5afa1bc370e2@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®